Shibboleth Developers

["Scott Cantor" <>]

> In the previous beta of opensaml, at line 219, was the test for
> HAVE_GOOD_STL.  It's not there anymore and causes builds to fail
> on my linux systems.  There is still a test for the definition in
> several sources.

It is included already in the config_pub.h header from xmltooling, and it
should be included in every source file from there before it ever gets
tested in any source code. If not, there's a serious header ordering bug
that needs to be fixed, but adding a copy of the test isn't the fix. Since I
don't see any errors in my builds, I don't know where the bug is. (I fixed
the MetadataImpl bug, I think, but that's distinct.)

I pulled the test because that was wrong...if xmltooling is built with that
macro defined, it's important that all the rest of the code also use it, and
vice versa. So it needs to be in one spot and then inherited rather than
retested, just in case that test ended up with a different answer. Not that
it would, but if somebody mixed code from different builds with different
compilers, it could.

-- Scott