Grouper Developers Forum

[Andrea Biancini <>]

Thanks Chris,

it seems quite clear to me!
So I have to configure a Grouper on my development workstation to have the tests running?

Tomorrow (here in Italy is 7pm) I will try to start and go through it!

One last question, I have this problem on GROUPER_2_2_BRANCH (see attached picture).

It seems that some source path is missing in grouper-ws. Should I lik those folder to some other in the worskspace?

How should I correct this?

Thansk!

A.

On Mon, Nov 3, 2014 at 6:59 PM, Chris Hyzer <> wrote:

Uh, volunteering to write tests????   Yes please!

 

Can you please work in v2_2?  I wrote a sample test there that works for me:

 

https://github.com/Internet2/grouper/commit/30ca9eeff26d52b58db6837c27bd9113bd5f3fb2

 

Note, that will delete your registry since it extends GrouperTest.  This is best so the registry is blank, test will be repeatable.

 

I use eclipse and that project has grouper-ws as a dependency which has “grouper” as a dependency, which is why the API and junit.jar etc are available…

 

Note, this doesn’t actually test the HTTP traffic and servlet, but it tests the business logic which I think is fine for now since the servlet works and shouldn’t change much, ok?   If you want we can add an end to end test later on…

 

Thanks,

Chris

 

From: Andrea Biancini [mailto:]
Sent: Monday, November 03, 2014 11:26 AM
To: Internet2/grouper
Cc: Chris Hyzer
Subject: Re: [grouper] Revied setters to eliminate warning in IDE (#16)

 

Thanks Chris,
honestly, I'm quite the test guy. In fact I think that with a proper design
testing we could be able to evaluate and accept contributions more easily
in the code streamline.

So, even if this is not for sure a priority activity, whenever you can we
could discuss the test strategy and the test approach you implemented for
grouper-ws.
If you can help me get started I can try to implement a full test case
suite also for this VOOT connector!

A.

On Mon, Nov 3, 2014 at 3:32 PM, mchyzer <> wrote:

> You are the one using it, so if it works for you, its fine for me ☺
> Testing the WS are kind of a pain, but if you have time at some point we
> can add some similar to the Grouper WS tests. Let me know at some point and
> I can help you get started…
>
> Thanks,
> Chris
>
> From: [mailto:
> ] On Behalf Of Andrea Biancini
> Sent: Monday, November 03, 2014 9:05 AM
> To: Chris Hyzer
> Cc: Internet2/grouper; Internet2/grouper;
> Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate
> warning in IDE (#16)
>
> Hi Chris,
> yes sorry for the commit on master. At Indianapolis we talked about having
> it placed on some branch on 2.1...
> But I actually had some problems and I ended up committing to master.
> Thanks for merging with 2.2.
>
> Regarding the Jira, thanks for the link.
> Do I have to do anything more?
> Testing/validation/verification?
>
> Cheers,
> Andrea
>
> On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <> >> wrote:
> Thanks Andrea!
>
> I thought we discussed this going to the v2_2 branch, but your pull
> requests were to master. I copied them back to v2_2. Also each change
> should have a jira, so I created you one:
>
> https://bugs.internet2.edu/jira/browse/GRP-1066
>
> Looks good.
>
> Regards,
> Chris
>
>
> From: Andrea Biancini []

> Sent: Monday, November 03, 2014 2:31 AM
> To: Internet2/grouper
> Subject: [grouper] Revied setters to eliminate warning in IDE (#16)
>
>
> Renamed setters params to avoid warnings in certain IDEs.
> (I do hate warnings in the IDE!)
>
> ________________________________
> You can merge this Pull Request by running
>
> git pull https://github.com/biancini/grouper master
>
> Or view, comment on, or merge it at:
>
> https://github.com/Internet2/grouper/pull/16
>
> Commit Summary
>
> * Revied setters to eliminate warning in IDE
>
> File Changes
>
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootEmail.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-0> (16)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGroup.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-1> (24)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootPerson.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-2> (24)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootErrorResponse.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-3> (12)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetGroupsResponse.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-4> (16)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetMembersResponse.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-5> (16)
> * M
> grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootResponse.java<
> https://github.com/Internet2/grouper/pull/16/files#diff-6> (18)
>
> Patch Links:
>
> * https://github.com/Internet2/grouper/pull/16.patch
> * https://github.com/Internet2/grouper/pull/16.diff
>
> —
> Reply to this email directly or view it on GitHub<
> https://github.com/Internet2/grouper/pull/16>.
>
>
>
> --
> Andrea Biancini
>
> e-mail: >

> web: andrea.biancini.googlepages.com<
> http://andrea.biancini.googlepages.com>
> tel: +39 333 2930873
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Internet2/grouper/pull/16#issuecomment-61485435>.
>



--
Andrea Biancini

e-mail:
web: andrea.biancini.googlepages.com
tel: +39 333 2930873

—
Reply to this email directly or view it on GitHub.

--

Andrea Biancini

e-mail:
web: andrea.biancini.googlepages.com

tel: +39 333 2930873

Attachment: PathError.png
Description: PNG image