grouper-dev - Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)
Please Wait...
grouper-dev@internet2.edu
Subject: Grouper Developers Forum
List archive
Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)
Chronological Thread
- From: Andrea Biancini <andrea.biancini@gmail.com>
- To: Chris Hyzer <mchyzer@isc.upenn.edu>
- Cc: "Internet2/grouper" <reply+i-47569112-0fadbd6c982218346c30478eac8d314d1aa54b7c-4495069@reply.github.com>, "Internet2/grouper" <grouper@noreply.github.com>, "grouper-dev@internet2.edu" <grouper-dev@internet2.edu>
- Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)
- Date: Mon, 3 Nov 2014 15:04:52 +0100
Thanks Andrea!
I thought we discussed this going to the v2_2 branch, but your pull requests were to master. I copied them back to v2_2. Also each change should have a jira, so I created you one:
https://bugs.internet2.edu/jira/browse/GRP-1066
Looks good.
Regards,
Chris
From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)
Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)
You can merge this Pull Request by running
git pull https://github.com/biancini/grouper masterOr view, comment on, or merge it at:
https://github.com/Internet2/grouper/pull/16
Commit Summary
- Revied setters to eliminate warning in IDE
File Changes
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootEmail.java (16)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGroup.java (24)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootPerson.java (24)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootErrorResponse.java (12)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetGroupsResponse.java (16)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetMembersResponse.java (16)
- M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootResponse.java (18)
Patch Links:
- https://github.com/Internet2/grouper/pull/16.patch
- https://github.com/Internet2/grouper/pull/16.diff
—
Reply to this email directly or view it on GitHub.
e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
- [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Chris Hyzer, 11/03/2014
- Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Andrea Biancini, 11/03/2014
- RE: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Chris Hyzer, 11/03/2014
- <Possible follow-up(s)>
- [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Chris Hyzer, 11/03/2014
- Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Andrea Biancini, 11/03/2014
- RE: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Chris Hyzer, 11/03/2014
- Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Andrea Biancini, 11/03/2014
- Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16), Andrea Biancini, 11/03/2014
Archive powered by MHonArc 2.6.16.