Skip to Content.
Sympa Menu

grouper-dev - Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)

Please Wait...

grouper-dev@internet2.edu

Subject: Grouper Developers Forum

List archive

Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)


Chronological Thread 
  • From: Andrea Biancini <andrea.biancini@gmail.com>
  • To: Chris Hyzer <mchyzer@isc.upenn.edu>
  • Cc: "Internet2/grouper" <reply+i-47569112-0fadbd6c982218346c30478eac8d314d1aa54b7c-4495069@reply.github.com>, "Internet2/grouper" <grouper@noreply.github.com>, "grouper-dev@internet2.edu" <grouper-dev@internet2.edu>
  • Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)
  • Date: Mon, 3 Nov 2014 15:04:52 +0100

Hi Chris,
yes sorry for the commit on master. At Indianapolis we talked about having it placed on some branch on 2.1...
But I actually had some problems and I ended up committing to master.
Thanks for merging with 2.2.

Regarding the Jira, thanks for the link.
Do I have to do anything more?
Testing/validation/verification?

Cheers,
Andrea

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <mchyzer@isc.upenn.edu> wrote:

Thanks Andrea!

 

I thought we discussed this going to the v2_2 branch, but your pull requests were to master.  I copied them back to v2_2.  Also each change should have a jira, so I created you one:

 

https://bugs.internet2.edu/jira/browse/GRP-1066

 

Looks good.

 

Regards,

Chris

 

 

From: Andrea Biancini [mailto:notifications@github.com]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

 

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)


You can merge this Pull Request by running

  git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

  https://github.com/Internet2/grouper/pull/16

Commit Summary

  • Revied setters to eliminate warning in IDE

File Changes

Patch Links:


Reply to this email directly or view it on GitHub.




--
Andrea Biancini

e-mail: andrea.biancini@gmail.com
web: andrea.biancini.googlepages.com
tel: +39 333 2930873



Archive powered by MHonArc 2.6.16.

Top of Page