Grouper Developers Forum

[Chris Hyzer <>]

You are the one using it, so if it works for you, its fine for me J  Testing the WS are kind of a pain, but if you have time at some point we can add some similar to the Grouper WS tests.  Let me know at some point and I can help you get started…

 

Thanks,

Chris

 

From: [mailto:] On Behalf Of Andrea Biancini
Sent: Monday, November 03, 2014 9:05 AM
To: Chris Hyzer
Cc: Internet2/grouper; Internet2/grouper;
Subject: Re: [grouper-dev] RE: [grouper] Revied setters to eliminate warning in IDE (#16)

 

Hi Chris,

yes sorry for the commit on master. At Indianapolis we talked about having it placed on some branch on 2.1...

But I actually had some problems and I ended up committing to master.

Thanks for merging with 2.2.

 

Regarding the Jira, thanks for the link.

Do I have to do anything more?

Testing/validation/verification?

 

Cheers,

Andrea

 

On Mon, Nov 3, 2014 at 2:34 PM, Chris Hyzer <> wrote:

Thanks Andrea!

 

I thought we discussed this going to the v2_2 branch, but your pull requests were to master.  I copied them back to v2_2.  Also each change should have a jira, so I created you one:

 

https://bugs.internet2.edu/jira/browse/GRP-1066

 

Looks good.

 

Regards,

Chris

 

 

From: Andrea Biancini [mailto:]
Sent: Monday, November 03, 2014 2:31 AM
To: Internet2/grouper
Subject: [grouper] Revied setters to eliminate warning in IDE (#16)

 

Renamed setters params to avoid warnings in certain IDEs.
(I do hate warnings in the IDE!)

---

You can merge this Pull Request by running

  git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

  https://github.com/Internet2/grouper/pull/16

Commit Summary

• Revied setters to eliminate warning in IDE

File Changes

• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootEmail.java (16)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGroup.java (24)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootPerson.java (24)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootErrorResponse.java (12)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetGroupsResponse.java (16)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetMembersResponse.java (16)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootResponse.java (18)

Patch Links:

• https://github.com/Internet2/grouper/pull/16.patch
• https://github.com/Internet2/grouper/pull/16.diff

—
Reply to this email directly or view it on GitHub.

 

--

Andrea Biancini

e-mail:
web: andrea.biancini.googlepages.com

tel: +39 333 2930873