Skip to Content.
Sympa Menu

grouper-dev - Re: [grouper-dev] Hello from Duke

Subject: Grouper Developers Forum

List archive

Re: [grouper-dev] Hello from Duke


Chronological Thread 
  • From: Shilen Patel <>
  • To: "GW Brown, Information Systems and Computing" <>
  • Cc:
  • Subject: Re: [grouper-dev] Hello from Duke
  • Date: Fri, 20 Jul 2007 13:52:51 -0400

I updated the class file, but there are still 6 invocations of PrepareRepositoryBrowserStemsAction.grouperExecute when entering the "Manage Groups" section with a user who has only 1 admin privilege. I haven't yet had any time to look into this in anymore detail.

Thanks,

-- Shilen


GW Brown, Information Systems and Computing wrote:
I've finally managed to take a look at this today, running my development environment with YourKit and the QuickStart database. As I expected there was only one invocation of:

PrepareRepositoryBrowserStemsAction.grouperExecute

when I clicked Manage Groups, however, I remembered a 'feature' of the UI which could explain your results - and which I can use to replicate them.

Usually the UI browses one level of the stem hierarchy at a time - giving the user the opportunity to choose which route to go. However, I added the 'feature' that if there was only one stem available to select - and the user did not have any management privileges for that stem or any groups at that level, the ui would automatically browse to the next stem for you. This process continues until the user can make a choice. So, I'm assuming that the user you selected was automatically stepped down 6 stems. Each step involves resetting the user's current position and then re-executing:

PrepareRepositoryBrowserStemsAction.grouperExecute

which explains why LoginCheckFilter.doFilter was only called once.

Is the next step quicker - or could a user then get stepped down several stems again?

In any case I've attached a new version of:

PrepareRepositoryBrowserStemsAction

which re-uses the previous 'RepositoryBrowser' each time it automatically steps down the stem hierarchy rather than ceating a new one. This ensures that hasAdmin etc are only called once no matter how many stems you are 'fast-forwarded' through.

Let me know if that helps and I'll add the changes to CVS.

Gary


--On 16 July 2007 16:18 -0400 Shilen Patel
<>
wrote:

All I did was the following to get the results that I sent you.

1. Log into the Grouper UI.
2. Start CPU profiling with YourKit.
3. Click on "Manage Groups" in the UI.
4. Waited for the page to load.
5. Stop CPU profiling with YourKit.


-- Shilen


GW Brown, Information Systems and Computing wrote:
Strange. I've attached the Eclipse debugger to Tomcat running the
Grouper UI and when I 'Manage groups' I only enter:
PrepareRepositoryBrowserStemsAction.grouperExecute

once although your YourKit output suggests 6 invocations.

On the other hand:

LoginCheckFilter.doFilter

has one invocation which is correct.

What steps did you use with YourKit?

Gary

--On 16 July 2007 11:20 -0400 Shilen Patel
<>
wrote:

With a person with few privileges, each call takes .1 seconds or less
using the API directly. Based off of results from YourKit, those
methods
are being called 6 times though. I've attached the method calls, time
per method, and invocation count for this operation in the UI.

Thanks,

-- Shilen



GW Brown, Information Systems and Computing wrote:


--On 14 July 2007 09:12 -0400

wrote:

After my index modifications, I'm not having problems with My
Memberships.
Good to hear.

Manage Groups for somebody with a few privileges takes about 14
seconds.
That seems very slow. The UI calls:

member.hasAdmin();
member.hasUpdate();
member.hasStem();
member.hasCreate();

however, each call should be quick for someone with few privileges
unless there is still a database index problem. I`d be interested to
know how long each call takes for a subject with few privileges.
For
the TA Admins, it takes several minutes.



----------------------
GW Brown, Information Systems and Computing





----------------------
GW Brown, Information Systems and Computing





----------------------
GW Brown, Information Systems and Computing





Archive powered by MHonArc 2.6.16.

Top of Page