COmanage Developers List

[Benn Oshrin <>]

performRedirect() should be run in any model that doesn't 
requires_person, otherwise those models won't return to /index after a 
delet. Most models don't requires_person.

On 9/17/12 5:45 PM, Marie Huynh wrote:
> This is in delete() in Standard Controller:
>
>      if(!$this->restful)
>      {
>        // Delete doesn't have a view, so we need to redirect back to
> index regardless of success
>        if($this->requires_person)
>          $this->checkPersonID("force", $op);
>        else
>          $this->performRedirect();
>      }
>
>
> performRedirect(); isn't necessarily run.  Is there a reason for this
> and does anything depend on this being the way it is?
>
> On Fri, Sep 14, 2012 at 10:34 AM, Heather Flanagan 
> <
> <mailto:>>
>  wrote:
>
>     Some highlights from today's Dev call:
>
>     Dev business
>
>          naming scheme for variables
>              the variable in question is the one added to the model or
>     controller; there is no specific standard, but generally variables
>     should be readable and understandable and ok if they are a little
>     bit longer
>          CO-438 discussion
>              see email thread to comanage-dev from Marie starting
>     10-Sep-2012
>     @ 11:53
>              punch list for ticket:
>
>          need tabified view for CO org people and edit tabs out of CO Person
>     Roles
>     (https://coriander.phys.uwm.edu/gears/co_person_roles/edit/1/co:1);
>          deleting an email address doesn't take you back to the same tab
>     (but
>     it should);
>          this view
>     https://coriander.phys.uwm.edu/gears/org_identities/edit/1/co:1/tab:email
>     vs
>     that view
>     https://coriander.phys.uwm.edu/gears/co_people/edit/1/co:1/tab:email
>     (make the CO Person bar like the CO Org Person bars
>
>          Keep the tiger stripes
>          Keep the vertical white line
>          The CO people groups tab requires the pencil icon