COmanage Developers List

[Benn Oshrin <>]

Did I mention we'll likely have a conflict for whoever commits second? :)

I need to work some UI elements because the long standing assumption that there is only one org identity per co person is going away. Shouldn't be too hard to merge.

My update: same as Monday.

Marie Huynh <> wrote:

Did: fixed tab redirects for delete for all controllers except for groups; might have uncovered another bug I need to track down

Will do: UI changes and digging the bug out.  Will need to cut some more tickets for refactoring(most of checkPersonId() is redirects; terrible for maintenance and legibility*), bugs, and splitting ticket to limit scope.

Blockers: none

*In particular:

      if($this->requires_person)

        $this->checkPersonID("force", $op);

      else

        $this->performRedirect();

It's not obvious that checkPersonID contains mostly code for redirection.  The name of the function implies that all it does is check the ID and the surrounding code implies that redirection is done via performRedirect();  This will require some refactoring at some point.

Marie