Skip to Content.
Sympa Menu

comanage-dev - [comanage-dev] scrum

Subject: COmanage Developers List

List archive

[comanage-dev] scrum


Chronological Thread 
  • From: Marie Huynh <>
  • To: comanage-dev <>
  • Subject: [comanage-dev] scrum
  • Date: Wed, 19 Sep 2012 04:57:45 -0700

Did: fixed tab redirects for delete for all controllers except for groups; might have uncovered another bug I need to track down
Will do: UI changes and digging the bug out.  Will need to cut some more tickets for refactoring(most of checkPersonId() is redirects; terrible for maintenance and legibility*), bugs, and splitting ticket to limit scope.
Blockers: none

*In particular:

      if($this->requires_person)
        $this->checkPersonID("force", $op);
      else
        $this->performRedirect();

It's not obvious that checkPersonID contains mostly code for redirection.  The name of the function implies that all it does is check the ID and the surrounding code implies that redirection is done via performRedirect();  This will require some refactoring at some point.

Marie



Archive powered by MHonArc 2.6.16.

Top of Page