COmanage Developers List

[Benn Oshrin <>]

OK, is there anything left on this one or is it done?

On 8/23/12 1:57 AM, Marie Huynh wrote:
> Done and uploaded to Coriander
>
> On Wed, Aug 22, 2012 at 7:23 PM, Benn Oshrin 
> <>
>  wrote:
> > I just noticed that the CO Person tabs have table headers in each tab,
> > whereas the Org Identity tabs don't. This is presumably because the CO
> > Person view is also used with "compare", but it feels a bit inconsistent.
> >
> > I'm thinking we ditch them from CO Person, except when comparing.
> >
> > Thoughts?
> >
> > -Benn-
> >
> >
> > On 8/22/12 8:54 PM, Marie Huynh wrote:
> > > As per this morning's discussion, I've removed the add buttons from
> > > the view, changed the title of the tab, and swapped an nbsp for the
> > > space so it's wider.
> > >
> > > On Tue, Aug 21, 2012 at 9:51 PM, Marie Huynh 
> > > <>
> > > wrote:
> > > > I ran into some mysterious problems with Coriander earlier but it
> > > > mysteriously started working again.  Can you take a look?
> > > >
> > > > On Tue, Aug 14, 2012 at 6:51 PM, Benn Oshrin 
> > > > <>
> > > >  wrote:
> > > > > Let's discuss tomorrow.
> > > > >
> > > > >
> > > > > On 8/14/12 8:56 PM, Marie Huynh wrote:
> > > > > > I worked on orgIDs first, and the idea of tabs came up while I was
> > > > > > working on copeople later.  If converting to tabs, there would be the
> > > > > > same number so not faster.
> > > > > >
> > > > > > Tabs for co people:
> > > > > >        Name
> > > > > >        Identifiers
> > > > > >        Email
> > > > > >        Groups
> > > > > >        Role Attributes
> > > > > >
> > > > > > Tabs for orgIDs:
> > > > > >        Organizational Identity (Name/other stuff in form)
> > > > > >        Identifiers
> > > > > >        Email
> > > > > >        Phone
> > > > > >        Address
> > > > > >
> > > > > > There isn't much data in each tab for the orgid view either, and I
> > > > > > thought it would be better to be able to see everything at a glance
> > > > > > rather than have to click for every bit of info.  Or are we expecting
> > > > > > people to have enough of any of them to require tabs?
> > > > > >
> > > > > >
> > > > > > On Tue, Aug 14, 2012 at 3:49 PM, Benn Oshrin 
> > > > > > <>
> > > > > > wrote:
> > > > > > > Wait, didn't you tab co_people? In which case org_identities should be
> > > > > > > easier because it's smaller...
> > > > > > >
> > > > > > >
> > > > > > > On 8/14/12 5:30 PM, Marie Huynh wrote:
> > > > > > > > We talked about having copeople tabbed but I didn't know you wanted
> > > > > > > > that tabbed too.  You didn't want a label for the first box.  What
> > > > > > > > tabs should there be?  I'm concerned that there will be too many to
> > > > > > > > fit with a sidebar.
> > > > > > > >
> > > > > > > > On Mon, Aug 13, 2012 at 6:38 PM, Benn Oshrin 
> > > > > > > > <>
> > > > > > > > wrote:
> > > > > > > > > I like where this is going. Perhaps we should do a call tomorrow to
> > > > > > > > > nitpick
> > > > > > > > > some stuff?
> > > > > > > > >
> > > > > > > > > I thought org_identities was going to be tabbed as well?
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 8/10/12 9:18 PM, Marie Huynh wrote:
> > > > > > > > > > https://coriander.phys.uwm.edu/gears/co_people/compare/1/co:1
> > > > > > > > > > https://coriander.phys.uwm.edu/gears/org_identities/edit/1/co:1
> > > > > > > > > >
> > > > > > > > > > Coriander still has a few issues but AFAIK they shouldn't affect
> > > > > > > > > > this
> > > > > > > > > > demo.  There are still some layout bugs that only show up in
> > > > > > > > > > Firefox.
> > > > > > > > > > I kept the layout of role attributes, though the action buttons are
> > > > > > > > > > still on the right for that while they're on the left for the
> > > > > > > > > > others.
> > > > > > > > > > The changes to add a sidebar in are out of the scope of this
> > > > > > > > > > ticket; I
> > > > > > > > > > only uploaded what is in the latest diff and would be committed.
> > > > > > > > > >
> > > > > > > > > > On Fri, Aug 10, 2012 at 5:34 AM, Marie Huynh
> > > > > > > > > > <>
> > > > > > > > > > wrote:
> > > > > > > > > > > Here's a diff.  I'll send a link to a demo later today.
> > > > > > > > > > >
> > > > > > > > > > > On Fri, Aug 3, 2012 at 8:43 AM, Benn Oshrin 
> > > > > > > > > > > <>
> > > > > > > > > > > wrote:
> > > > > > > > > > > > Getting there... let's take a few minutes on today's call to
> > > > > > > > > > > > nitpick
> > > > > > > > > > > > some
> > > > > > > > > > > > more.
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On 8/1/12 7:47 PM, Marie Huynh wrote:
> > > > > > > > > > > > > Hi all,
> > > > > > > > > > > > >
> > > > > > > > > > > > > This is the latest version:
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > https://skitch.com/mariehuynh/ek8gj/comanage-registry-edit-organizational-identity
> > > > > > > > > > > > >
> > > > > > > > > > > > > I think it's more obvious now that the save and cancel buttons
> > > > > > > > > > > > > are
> > > > > > > > > > > > > associated with the form and not the other elements in the box
> > > > > > > > > > > > > on
> > > > > > > > > > > > > the
> > > > > > > > > > > > > right side.  I removed the zebra pattern and rearranged the
> > > > > > > > > > > > > elements
> > > > > > > > > > > > > now
> > > > > > > > > > > > > on the right to have headers(in default ui style) to emphasize
> > > > > > > > > > > > > that
> > > > > > > > > > > > > they
> > > > > > > > > > > > > are their own type of information.  Let me know what you think.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Marie
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Tue, Jul 31, 2012 at 5:36 PM, Marie Huynh
> > > > > > > > > > > > > <
> > > > > > > > > > > > > <mailto:>>
> > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >                       It looks a little weird as is... perhaps
> > > > > > > > > > > > > the
> > > > > > > > > > > > > two
> > > > > > > > > > > > > boxes
> > > > > > > > > > > > >                  can be forced
> > > > > > > > > > > > >                       to be the same height?
> > > > > > > > > > > > >
> > > > > > > > > > > > >                  They will be closer in height after I'm done
> > > > > > > > > > > > > with
> > > > > > > > > > > > > the
> > > > > > > > > > > > >                  changes, but the
> > > > > > > > > > > > >                  right needs to be allowed to grow with the
> > > > > > > > > > > > > addition
> > > > > > > > > > > > > of
> > > > > > > > > > > > > more
> > > > > > > > > > > > >                  items.
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >              How weird will it look if the left and right grow at
> > > > > > > > > > > > > the
> > > > > > > > > > > > > same
> > > > > > > > > > > > >              pace? ie: Left gets blank padded at the bottom to
> > > > > > > > > > > > > match
> > > > > > > > > > > > > right's
> > > > > > > > > > > > >              height when right is taller.
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >          We were just trying to visually separate the two sets of
> > > > > > > > > > > > >          fields/buttons.  I don't think it makes sense to force
> > > > > > > > > > > > > them
> > > > > > > > > > > > > to
> > > > > > > > > > > > > match
> > > > > > > > > > > > >          with extra space.  It's also ugly to do with CSS,
> > > > > > > > > > > > > meaning it
> > > > > > > > > > > > >          requires javascript or other hacks, or going back to
> > > > > > > > > > > > > tables.
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >                       And maybe the border should become a thin
> > > > > > > > > > > > > black
> > > > > > > > > > > > > line
> > > > > > > > > > > > >                  instead of
> > > > > > > > > > > > >                       thicker (line2 color)?
> > > > > > > > > > > > >
> > > > > > > > > > > > >               >
> > > > > > > > > > > > >
> > > > > > > > > > > > >                  Clarify?
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >              Looking at the latest version, it appears we're
> > > > > > > > > > > > > using
> > > > > > > > > > > > > three
> > > > > > > > > > > > > gray
> > > > > > > > > > > > >              colors: line1, line2, and the border. I guess this
> > > > > > > > > > > > > is
> > > > > > > > > > > > > OK,
> > > > > > > > > > > > > though
> > > > > > > > > > > > >              perhaps the contrast could be improved.
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > https://skitch.com/mariehuynh/ej93g/comanage-registry-edit-organizational-identity
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > https://skitch.com/mariehuynh/ej92d/comanage-registry-edit-organizational-identity
> > > > > > > > > > > > >
> > > > > > > > > > > > >              We should start cc'ing Heather :)
> > > > > > > > > > > > >
> > > > > > > > > > > > >              -Benn-