Skip to Content.
Sympa Menu

comanage-dev - Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery

Subject: COmanage Developers List

List archive

Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery


Chronological Thread 
  • From: Benn Oshrin <>
  • To: Marie Huynh <>
  • Cc:
  • Subject: Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery
  • Date: Thu, 21 Jun 2012 22:45:58 -0400

On 6/18/12 8:04 PM, Marie Huynh wrote:
I've attached a diff of the changes I've made.

On Wed, Jun 13, 2012 at 4:09 PM, Benn Oshrin
<
<mailto:>>
wrote:

On 6/13/12 5:41 PM, Marie Huynh wrote:

Should it be tacked onto cm_co_enrollment_flows then?


I think so. I added "notify_from" to

https://spaces.internet2.edu/__display/COmanage/cm_co___enrollment_flows
<https://spaces.internet2.edu/display/COmanage/cm_co_enrollment_flows>

(but didn't do anything in src). I think this gives good
flexibility, although it could get annoying if you need to define a
lot of flows.


Let's put off the redesign for the moment, which means
sticking with
the lang file approach. Let's keep the text short, on the
assumption
that people will want to change it anyway. For demo purposes it
could be something like
Did you forget to finish a thought here? :D


Huh, no I think I was deleting something I wrote and didn't finish
deleting it...


I agree with Scott. It was only on the confirmation page because
email wasn't being sent.

You might consider checking for debug mode, and if in debug mode
display the URL otherwise don't.

debug($somevar) does the check and only prints if level>0. Did
we make
a decision about [not] committing debug statements a while back?


We probably need a little more than debug($somevar), since we should
have some text explaining what the URL is. Maybe.

We can review our debug decision if appropriate.

-Benn-







Archive powered by MHonArc 2.6.16.

Top of Page