comanage-dev - Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery
Subject: COmanage Developers List
List archive
- From: Marie Huynh <>
- To: Benn Oshrin <>
- Cc:
- Subject: Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery
- Date: Mon, 18 Jun 2012 17:04:57 -0700
I've attached a diff of the changes I've made.
On Wed, Jun 13, 2012 at 4:09 PM, Benn Oshrin <> wrote:
On 6/13/12 5:41 PM, Marie Huynh wrote:I think so. I added "notify_from" to
Should it be tacked onto cm_co_enrollment_flows then?
https://spaces.internet2.edu/display/COmanage/cm_co_enrollment_flows
(but didn't do anything in src). I think this gives good flexibility, although it could get annoying if you need to define a lot of flows.Huh, no I think I was deleting something I wrote and didn't finish deleting it...
Let's put off the redesign for the moment, which means sticking with
the lang file approach. Let's keep the text short, on the assumption
that people will want to change it anyway. For demo purposes it
could be something like
Did you forget to finish a thought here? :D
We probably need a little more than debug($somevar), since we should have some text explaining what the URL is. Maybe.
I agree with Scott. It was only on the confirmation page because
email wasn't being sent.
You might consider checking for debug mode, and if in debug mode
display the URL otherwise don't.
debug($somevar) does the check and only prints if level>0. Did we make
a decision about [not] committing debug statements a while back?
We can review our debug decision if appropriate.
-Benn-
Attachment:
co352.diff
Description: Binary data
- [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/11/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Scott Koranda, 06/12/2012
- Message not available
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/18/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/21/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/23/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Benn Oshrin, 06/13/2012
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 06/13/2012
- Message not available
- Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Scott Koranda, 06/12/2012
Archive powered by MHonArc 2.6.16.