COmanage Developers List

[Marie Huynh <>]

Whoops, forgot the list again.

On Tue, Jun 12, 2012 at 10:56 PM, Marie Huynh <> wrote:

On Tue, Jun 12, 2012 at 7:51 PM, Scott Koranda <> wrote:

> A few questions:
>
> * What should the default email address for all emails from CoManage be?
> ?  This will be set in the config file(email.php); I should
> update the installation instructions once that's figured out.

I will defer to others...

>
> * How do we want to internationalize the email messages?  The same lang file as
> we've been doing?  This is potentially long and messy, depending on how many
> email messages are to be sent from the system.

Do you have another proposal?

The cake book (http://book.cakephp.org/2.0/en/core-libraries/internationalization-and-localization.html) offers three options for internationalization, none of which we are using right now.  I am inclined to continue using the lang file for consistency's sake for now and convert it completely to one of those later, but I don't know when we'll get to it.  I'm sure we have an internationalization ticket floating around in jira somewhere though.

>
> * What should be displayed on the sent page?  It currently says(based on
> send.ctp):
>
>     Invitation for asdf Sent to asdf
>     Email would be sent to with the URL
>
>     http://localhost/gears/trunk/co_invites/reply/
>     54b7b18716e7ac036efb76bec2f32213d3636e9b
>
>
> I think it's good to keep the page so that there is confirmation that the
> invitation was successfully sent.  I'm thinking something like:
> Your invitation has been sent to <some name> at <some email> with this URL this
> link for further action:
> http://wherever.com/co_invites/reply/hexhexhexhexhexhex

I would not include the URL--people will surely click on it
even though the invitation is not meant for them.

 

Good point.  Should we even display it on the confirmation page then? 

Marie

>
> As for refactoring send, the function is about 175 lines long.  Ugh.  How much
> of that is really specific to the invitations and how much can be reused
> elsewhere on the site?  Does it make sense to refactor it out of CoInvites?

Again, I defer to Benn...

Does CakePHP 2.x have a "nice" way to handle email? 

Thanks,

Scott

>
> Marie
>
>
>
> On Fri, Jun 1, 2012 at 9:11 AM, Marie Huynh (JIRA) <>
> wrote:
> >
> >     [ https://bugs.internet2.edu/jira/browse/CO-352?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Work on CO-352 started by Marie Huynh.
> >
> >> Implement Email Delivery
> >> ------------------------
> >>
> >>                 Key: CO-352
> >>                 URL: https://bugs.internet2.edu/jira/browse/CO-352
> >>             Project: COmanage
> >>          Issue Type: Sub-task
> >>          Components: Registry
> >>    Affects Versions: COmanage Registry 0.5 (Shiny Basic Shape)
> >>            Reporter: Benn Oshrin
> >>            Assignee: Marie Huynh
> >>            Priority: Major
> >>              Labels: sprint07
> >>             Fix For: COmanage Registry 0.6 (Helpful Hexagon)
> >>
> >>
> >> Implement email sending in CoInvitesController::send() (look for "XXX email
> the invitation, don't just render it") using CakeEmail (http://book.cakephp.org
> /2.0/en/core-utility-libraries/email.html).
> >> This will require customizing the email configuration file, which should be
> done via the setup shell.
> >> View/CoInvites/send.ctp might need updating or to go away completely.
> >> Some or all of CoInvitesController::send() might be better off being
> refactored into the model.
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> administrators: https://bugs.internet2.edu/jira/secure/ContactAdministrators!
> default.jspa
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
> >
> >
>