COmanage Developers List

[Benn Oshrin <>]

On 6/18/12 8:04 PM, Marie Huynh wrote:
> I've attached a diff of the changes I've made.

Sorry about the earlier no content reply... key slip.

In CoInvitesController... is there a way to tell if send() failed? There 
are a number of different failure scenarios, some of which we might be 
able to get directly (invalid email address, php not configured 
correctly, etc) and some of which probably need to be handled by the 
mail delivery system (valid-looking undeliverable email address, etc).

Various @since should be v0.6, not v0.1. Also, the Copyright dates on 
the new files should just be 2012, not (eg) 2010-12.

html/basic.ctp uses echo $content_for_layout while text/basic.ctp uses 
print. They should be consistent and follow current guidelines.

In CoInvites/send.ctp, the string "Email has been sent to" should be 
turned into a _txt() call. Actually, better yet would be for send.ctp to 
go away, and an appropriate redirect issued, which the _txt() string put 
in a flash message. The redirect is probably back to "My Population" for 
now, though that could change.

Also, we still need to handle configuring the mail-from address.

Thanks,

-Benn-