COmanage Developers List

[Marie Huynh <>]

I made some more changes.  I hope I caught everything.

On Thu, Apr 5, 2012 at 4:30 PM, Benn Oshrin <> wrote:

Mostly random extra whitespace, and some things that are like

 bar
 {
  foo
 }

when they should be

 bar {
  foo
 }

I didn't make a full inventory.

Lining up html tags from php is, at this point, I think a lost cause :)

I was going to ask about the extra indentation for grouping CSS rules... I suspect we'll want to write something up on that.

-Benn-

On 4/5/12 6:42 PM, Marie Huynh wrote:

Is there a problem with the extra indentation to line up html tags being
output by php and extra indentation to group CSS rules?  Or are you
talking about random extra whitespace?

On Thu, Apr 5, 2012 at 10:53 AM, Benn Oshrin <

<mailto:>> wrote:

   On 4/3/12 4:13 PM, Marie Huynh wrote:

       Can you take a look at this revised diff?


   The only major comment I have is that there are a number of places
   where spacing and formatting aren't done according to the coding
   guidelines.

   Beyond that, I feel like AppController::menuAuth and menuContent
   should be somewhere other than AppController, but I don't have a
   good suggestion at the moment. Perhaps we'll just wait until
   AppController collapses under its own weight and we need to refactor it.

   -Benn-

Attachment: co80
Description: Binary data