COmanage Developers List

[Marie Huynh <>]

Can you take a look at this revised diff?

On Mon, Apr 2, 2012 at 6:20 AM, Benn Oshrin <> wrote:

I think your suggestion sounds good. The minor addition I'd add would be to put a comment in the close tag to make it easier to track which tag goes with which. eg:

 <?php if($foo): ?>
 <?php if($bar): ?>
 <?php endif; // bar ?>
 <?php endif; // foo ?>

I'll add a section to the style guide.

On 3/30/12 7:51 PM, Marie Huynh wrote:

As far as I know, there is no functional difference between using this:

<?php if(){ ?>
  stuff;
<?php } ?>

and this:

<?php if() : ?>
  stuff;
<?php endif; ?>

Benn, have you given any thought to this or found any reason to go with
one or the other since we talked about it?  I think it makes sense to
use the latter for parts of the view with lots of html that are much
cleaner with the controls split into different php tags, but unnecessary
if they are in the same <?php ?>.  Does that sound like a good guideline?

Marie

Attachment: co80
Description: Binary data