comanage-dev - Re: [comanage-dev] CO-80 diff

Subject: COmanage Developers List

List archive

Re: [comanage-dev] CO-80 diff

From: Benn Oshrin <>
To: Marie Huynh <>
Cc:
Subject: Re: [comanage-dev] CO-80 diff
Date: Thu, 05 Apr 2012 13:53:44 -0400

On 4/3/12 4:13 PM, Marie Huynh wrote:

Can you take a look at this revised diff?

The only major comment I have is that there are a number of places where spacing and formatting aren't done according to the coding guidelines.

Beyond that, I feel like AppController::menuAuth and menuContent should be somewhere other than AppController, but I don't have a good suggestion at the moment. Perhaps we'll just wait until AppController collapses under its own weight and we need to refactor it.

-Benn-

Re: [comanage-dev] endif vs braces, Benn Oshrin, 04/02/2012
- Re: [comanage-dev] endif vs braces, Marie Huynh, 04/03/2012
  - Re: [comanage-dev] CO-80 diff, Benn Oshrin, 04/05/2012
    - Message not available
      - Message not available
        
        Re: [comanage-dev] CO-80 diff, Marie Huynh, 04/10/2012
        
        Re: [comanage-dev] CO-80 diff, Benn Oshrin, 04/13/2012

List archive

Re: [comanage-dev] CO-80 diff