Shibboleth Developers

[Chad La Joie <>]

Here's the resolution on all the issues Tom brought up.

> - Targets clean-install and install.idp.filesystem in build.xml invoke the 
> task
>   <delete dir="${idp.home}/etc" />
> The latter is benign and can be safely removed but the delete task in
> clean-install is a potentially serious problem.

Target clean-install has been removed.

> - Target ext-build-init in extension-build.xml emits a message re
> default-build.properties, which doesn't exist.

Fixed.

> - Target ext-copy-src-conf in extension-build.xml emits a message re
> the 'etc' directory, which is false.

Fixed.

> - Invoking ext-compile (independent of ext-build) in
> extension-build.xml produces no class files since ext-compile does not
> depend on ext-build-init.
>
> - Target ext-copy-libs in extension-build.xml depends on ext-compile
> instead of ext-build-init.
>
> - Target ext-copy-webpages in extension-build.xml depends on
> ext-compile instead of ext-build-init.
>
> - Invoking ext-gen-docs (independent of ext-build) in
> extension-build.xml produces no javadoc files since ext-gen-docs does
> not depend on ext-build-init.
>
> - Invoking ext-package (independent of ext-build) in
> extension-build.xml produces an empty JAR file since ext-package does
> not depend on both ext-compile and ext-copy-src-conf.

Will not be addressed in this release.

> - Target clean-javadocs in build.xml should clean extension javadocs as well.

Fixed.

> - Reverse the order of sections 2.1 and 2.2 in README.txt.

Left as it was.

> - Add the following nested element to the <javadoc> element in
> extension-build.xml:
>   <link href="http://java.sun.com/j2se/1.5.0/docs/api/"/>

Fixed.

> - Add attribute deprecation="true" to the <javac> element in
> extension-build.xml.

Fixed.

> - There's a reference to "build-exts" (which doesn't exist) in a
> comment in extension-build.xml.

Fixed.

> - The comment prior to ext-package in extension-build.xml says
> parameter ext.build.function is required, which is false.

Fixed.

> - The location of the javadocs is nonstandard with respect to the rest
> of the project so the following workaround is in place in the GridShib
> extension's build.properties file:
>   gridshib.doc=doc
>   gridshib.javadocs=${gridshib.doc}/api
>   ext.docs=${ext.root}/${gridshib.javadocs}

Fixed.

> - The GridShib extension is already using directory dist/ for a
> different purpose (similar to the OpenSAML project) so the following
> workaround is in place in the extension's build.properties file:
>   gridshib.build=build
>   ext.dist=${ext.root}/${gridshib.build}

Fixed.

> - Mention the throwaway directories ext.dist, ext.classes, and
> ext.docs in README.txt so extension developers are aware of the
> potential conflicts.

Fixed.

> - Property ext.name is used for dual purposes.  In almost all cases,
> it's value should be lowercase (as in "gridshib") but where it's used
> in the <javadoc> element, it should be mixed case ("GridShib").  How
> can this be reconciled?

Left as it was.
--
Chad La Joie             315Q St. Mary's Hall
Project Sentinel         202.687.0124