Shibboleth Developers

[Ian Young <>]

As at build.xml rev 1.66, the package-idp and package-sp tasks depend on 
properties called idp.home.url and sp.home.url.  Those are created by a 
task called install.url, but that task isn't a dependency for the other two.

The symptom is that you get rubbish in the generated XML files.

I'm assuming the reason no-one else hits this is that they don't call 
package-idp and package-sp directly, but indirectly as part of something 
that does call install.url.

I attach a patch to fix this.

    -- Ian
Index: build.xml
===================================================================
RCS file: /home/cvs/shibboleth/shibboleth/java/build.xml,v
retrieving revision 1.66
diff -u -r1.66 build.xml
--- build.xml   28 Jun 2005 18:21:57 -0000      1.66
+++ build.xml   5 Jul 2005 12:28:28 -0000
@@ -254,7 +254,7 @@
 
     
        <!-- Package Shibboleth -->
-    <target name="package-idp" depends="compile" description="Creates the 
IdP war file and moves it to ${dist}">
+    <target name="package-idp" depends="compile, install.url" 
description="Creates the IdP war file and moves it to ${dist}">
        <!-- copy values to deployment descriptor -->
         <copy file="${configroot}/${idp.deployment.descriptor}" 
tofile="${configroot}/idp.xml" overwrite="true" />
         <replace file="${configroot}/idp.xml" token="$SHIB_HOME$" 
value="${idp.home.url}" />
@@ -270,7 +270,7 @@
         <war warfile="${dist}/${distnameWayf}.war" 
webxml="${configroot}/wayf.xml" basedir="${approot}" update="no" />
     </target>
        
-    <target name="package-sp" depends="compile" description="Creates the 
Java SP war and moves it to ${dist}">
+    <target name="package-sp" depends="compile, install.url" 
description="Creates the Java SP war and moves it to ${dist}">
        <!-- copy values to deployment descriptor -->
         <copy file="${configroot}/${sp.deployment.descriptor}" 
tofile="${configroot}/sp.xml" overwrite="true" />
         <replace file="${configroot}/sp.xml" token="$SHIB_HOME$" 
value="${sp.home.url}" />