Skip to Content.
Sympa Menu

shibboleth-dev - RE: Redesigned target checked in

Subject: Shibboleth Developers

List archive

RE: Redesigned target checked in


Chronological Thread 
  • From: Scott Cantor <>
  • To: 'Derek Atkins' <>
  • Cc:
  • Subject: RE: Redesigned target checked in
  • Date: Mon, 19 Jan 2004 21:33:26 -0500
  • Importance: Normal
  • Organization: The Ohio State University

> *sigh* This is why I want to restructure the code and more even more
> shib stuff OUT of the modules. There is STILL way way WAY too much
> duplicated code.

Well, I'm not sure how to move this out and really accomplish much, since
the actual header export operation is server-specific. You could arguably
loop over the assertions in a shared function and build a big array of
header values, but I think it's just a waste of memory to buffer everything
multiple times.

I think we unset any header that could potentially get exported up front, so
the fix for this bug is just to see if there's already a value for a header,
and if so append to it instead of resetting it from scratch.

-- Scott




Archive powered by MHonArc 2.6.16.

Top of Page