NDT-DEV email list created

[GitHub <>]

  Branch: refs/heads/master
  Home:   https://github.com/ndt-project/ndt
  Commit: f781862a0c436740c3b5273ff02b4913be343879
      
https://github.com/ndt-project/ndt/commit/f781862a0c436740c3b5273ff02b4913be343879
  Author: Peter Boothe 
<>
  Date:   2016-05-11 (Wed, 11 May 2016)

  Changed paths:
    M src/test_c2s_srv.c
    M src/web100srv.c
    M src/web100srv_unit_tests.c

  Log Message:
  -----------
  Three small bugfixes, one of which was causing real issues for MLab servers 
in developing nations.
A one-line compiler wanring fix for test_c2s.
Fixing watchdog timer issues in web100srv.  (The server bug)
Making end-to-end unit tests less flaky by no longer just assuming that every 
port in the range [1024, 31024) is fine for the server to take as its own.


  Commit: ddae85dbaeb8fc93cd67aed64d8ce6d7f3e7bc5e
      
https://github.com/ndt-project/ndt/commit/ddae85dbaeb8fc93cd67aed64d8ce6d7f3e7bc5e
  Author: Peter Boothe 
<>
  Date:   2016-05-13 (Fri, 13 May 2016)

  Changed paths:
    M HTML5-frontend/Makefile.am

  Log Message:
  -----------
  Merge branch 'dev' of github.com:m-lab/ndt into dev


  Commit: 71b77393ed16aec015f5070bd29966b08bdc4d90
      
https://github.com/ndt-project/ndt/commit/71b77393ed16aec015f5070bd29966b08bdc4d90
  Author: Peter Boothe 
<>
  Date:   2016-06-08 (Wed, 08 Jun 2016)

  Changed paths:
    M src/Makefile.am
    M src/test_c2s_srv.c
    M src/test_s2c_srv.c
    A src/testutils.c
    A src/testutils.h

  Log Message:
  -----------
  Merge branch 'dev' of github.com:m-lab/ndt into dev


  Commit: a8e55a3623b094555d61063f39c08bf6d59c32ea
      
https://github.com/ndt-project/ndt/commit/a8e55a3623b094555d61063f39c08bf6d59c32ea
  Author: Peter Boothe 
<>
  Date:   2016-06-08 (Wed, 08 Jun 2016)

  Changed paths:
    M src/testoptions.c
    M src/web100srv.c

  Log Message:
  -----------
  Merge branch 'dev' of github.com:m-lab/ndt into dev


  Commit: b1380195309aed4ca55a312d1ceb8ff4f91642e3
      
https://github.com/ndt-project/ndt/commit/b1380195309aed4ca55a312d1ceb8ff4f91642e3
  Author: Peter Boothe 
<>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M src/network.c
    M src/testoptions.c
    M src/web100srv.c
    M src/web100srv.h
    M src/websocket.c

  Log Message:
  -----------
  Merge branch 'dev' of github.com:m-lab/ndt into dev


  Commit: 997629ff8c913b2e644c706cefd3d6b96324e4af
      
https://github.com/ndt-project/ndt/commit/997629ff8c913b2e644c706cefd3d6b96324e4af
  Author: Peter Boothe 
<>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M src/web100srv.c

  Log Message:
  -----------
  Makes the server's SSL setup as cross-compatible as OpenSSL can possibly be.

Eliminates session caching, as a proper implementation of session caching
requires IPC when you have a server that forks, and we avoid unnecessary IPC 
in
pursuit of simplicity.


  Commit: ce4d15ce7062af16fa806cec892888262913edc6
      
https://github.com/ndt-project/ndt/commit/ce4d15ce7062af16fa806cec892888262913edc6
  Author: Peter Boothe 
<>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M src/network.c

  Log Message:
  -----------
  Update error handling for SSL to be pedantically correct.


  Commit: 76e4922b39b8f9e15f653b4506c7eeaaf92f40ab
      
https://github.com/ndt-project/ndt/commit/76e4922b39b8f9e15f653b4506c7eeaaf92f40ab
  Author: Peter Boothe 
<>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M src/web100srv.c

  Log Message:
  -----------
  Merge pull request #63 from pboothe/ssl_signals

Makes the server's SSL setup as cross-compatible as possible


  Commit: a14f50f1e4613d67124e570bf488d842fd514a8c
      
https://github.com/ndt-project/ndt/commit/a14f50f1e4613d67124e570bf488d842fd514a8c
  Author: Peter Boothe 
<>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M src/network.c

  Log Message:
  -----------
  Cleanup of comment grammar, and clearer handling of errno.


  Commit: e8804f10421d167b66c855723584212ed38a0ba6
      
https://github.com/ndt-project/ndt/commit/e8804f10421d167b66c855723584212ed38a0ba6
  Author: Peter Boothe 
<>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M src/network.c

  Log Message:
  -----------
  Merge pull request #64 from pboothe/ssl_error_handling

Update error handling for SSL to be correct.


  Commit: fe3f69e28e50f511e216210b2b8c85564eaacdb5
      
https://github.com/ndt-project/ndt/commit/fe3f69e28e50f511e216210b2b8c85564eaacdb5
  Author: Peter Boothe 
<>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M src/web100-pcap.c
    M src/web100srv.c

  Log Message:
  -----------
  Adds the watchdog timer as the very first thing, and eliminates the "return"
from the error paths which is never the right thing and is potentially
disastrous.

Also, eliminates a string from a log line which frequently ended up being a
pointer to memory that did not contain a string.


  Commit: aa8af48cfc0d4caf62da3debb959f404c1b8c010
      
https://github.com/ndt-project/ndt/commit/aa8af48cfc0d4caf62da3debb959f404c1b8c010
  Author: Peter Boothe 
<>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M src/web100-pcap.c

  Log Message:
  -----------
  Completed the removal of the string.


  Commit: 0f853ef9d8fc49610d0dfbdf07294aca7fbcac7b
      
https://github.com/ndt-project/ndt/commit/0f853ef9d8fc49610d0dfbdf07294aca7fbcac7b
  Author: Peter Boothe 
<>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M src/web100-pcap.c
    M src/web100srv.c

  Log Message:
  -----------
  Merge pull request #65 from pboothe/tiny_cleanups

Watchdog timer, error path bugfixes, and a logging cleanup.


  Commit: 1ae4db846a6493f07575094100502997cf46e4d9
      
https://github.com/ndt-project/ndt/commit/1ae4db846a6493f07575094100502997cf46e4d9
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.c

  Log Message:
  -----------
  ssl_error, not ssl_errno.


  Commit: dbab3550da46c12cc84abe1eb4b3e057efccc777
      
https://github.com/ndt-project/ndt/commit/dbab3550da46c12cc84abe1eb4b3e057efccc777
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.c

  Log Message:
  -----------
  Merge pull request #66 from pboothe/tiny_cleanups

ssl_error, not ssl_errno.


  Commit: 31fba31046da4bb74fb0e20e659c3ded82fcd99f
      
https://github.com/ndt-project/ndt/commit/31fba31046da4bb74fb0e20e659c3ded82fcd99f
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.c
    M src/network.h
    M src/test_c2s_srv.c

  Log Message:
  -----------
  Updated error handling and logging.  Added robustness to test_c2s


  Commit: 4491709354e37786e88e712adb9c48e2afb6218e
      
https://github.com/ndt-project/ndt/commit/4491709354e37786e88e712adb9c48e2afb6218e
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/test_c2s_srv.c

  Log Message:
  -----------
  Clear the error stack before SSL functions


  Commit: 381d53db946518883551f1741ff28102e597679e
      
https://github.com/ndt-project/ndt/commit/381d53db946518883551f1741ff28102e597679e
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.h
    M src/test_c2s_srv.c

  Log Message:
  -----------
  Better logging


  Commit: 82ec3bcae15717942e2943ff04465dcc9e357c67
      
https://github.com/ndt-project/ndt/commit/82ec3bcae15717942e2943ff04465dcc9e357c67
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/test_c2s_srv.c

  Log Message:
  -----------
  Log line now contains the function that returned the error


  Commit: cdd5f1c8375b12c730b3df1d2cddc90685d64281
      
https://github.com/ndt-project/ndt/commit/cdd5f1c8375b12c730b3df1d2cddc90685d64281
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.c
    M src/network.h
    M src/test_c2s_srv.c

  Log Message:
  -----------
  Merge pull request #67 from pboothe/test_ssl_robustness

Increase ssl robustness


  Commit: c571b8157fd70ca3a85b64c9e63c7e9081c05dbf
      
https://github.com/ndt-project/ndt/commit/c571b8157fd70ca3a85b64c9e63c7e9081c05dbf
  Author: Peter Boothe 
<>
  Date:   2016-07-21 (Thu, 21 Jul 2016)

  Changed paths:
    M src/network.c
    M src/network.h
    M src/test_c2s_srv.c
    M src/web100-pcap.c
    M src/web100srv.c

  Log Message:
  -----------
  Merge branch 'dev' of github.com:m-lab/ndt into dev


  Commit: 80dfef5368b5fba6da533f5eec5d54dae2240180
      
https://github.com/ndt-project/ndt/commit/80dfef5368b5fba6da533f5eec5d54dae2240180
  Author: Peter Boothe 
<>
  Date:   2016-07-27 (Wed, 27 Jul 2016)

  Changed paths:
    M src/web100srv.c

  Log Message:
  -----------
  Removed all controversial client bug workarounds, leaving only SSL_OP_ALL.

The man page says:
> It is usually safe to use SSL_OP_ALL to enable the bug workaround options 
> if compatibility with somewhat broken implementations is desired.


  Commit: 381a935fffc376fe6ab7f1ee6dd2a3be644b80d6
      
https://github.com/ndt-project/ndt/commit/381a935fffc376fe6ab7f1ee6dd2a3be644b80d6
  Author: Peter Boothe 
<>
  Date:   2016-07-28 (Thu, 28 Jul 2016)

  Changed paths:
    M src/web100srv.c

  Log Message:
  -----------
  Merge pull request #68 from pboothe/add_ssl_connect_logging

Remove controversial client bug workarounds.


  Commit: 9219d9f0e6092631592d5c3103f3d56ef886db8e
      
https://github.com/ndt-project/ndt/commit/9219d9f0e6092631592d5c3103f3d56ef886db8e
  Author: Peter Boothe 
<>
  Date:   2016-11-15 (Tue, 15 Nov 2016)

  Changed paths:
    M src/network.c
    M src/network.h
    M src/test_c2s_srv.c
    M src/test_s2c_srv.c
    M src/test_sfw_srv.c
    M src/testoptions.c
    M src/testoptions.h
    M src/web100-pcap.c
    M src/web100srv.c

  Log Message:
  -----------
  Fix hanging child process problem. (#71)

Back in the misty deeps of time (far enough back that we couldn't dig it out 
of revision control in a reliable way), we think that the test_s2c test used 
`alarm(10)` as its ten-second timer. To do this, it needed to install its own 
SIGALRM handler that was a no-op. Over time, the code was upgraded into a 
`while(time() < end_time)`-style loop, but the signal handling code was never 
removed.  Then, after the introduction of SSL, it became possible for 
test_s2c to cause a `read()` to occur in e.g. SSL renegotiation or the like.

This left us in the situation where if the client disappeared off the network 
(never sent a FIN that we received) when we were blocked in a `read()` call 
in test_s2c, the child process would just stay hung forever.  This bug was 
causing real production pain for MLab, so we finally tracked it down and we 
have tried to prevent it in a "belt & suspenders" manner by both ensuring 
that the watchdog timer is never disabled during test_s2c or test_c2s, and by 
installing socket timeouts on all communication sockets.

As with all changes to the NDT codebase, this small amount of code required a 
lot of archaeological detective work.

This fixes issue #71 .


  Commit: 647452036fadd825e1cd0e53ba930948beafc1ab
      
https://github.com/ndt-project/ndt/commit/647452036fadd825e1cd0e53ba930948beafc1ab
  Author: Peter Boothe 
<>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M src/network.c
    M src/network.h
    M src/test_c2s_srv.c
    M src/test_s2c_srv.c
    M src/test_sfw_srv.c
    M src/testoptions.c
    M src/testoptions.h
    M src/web100-pcap.c
    M src/web100srv.c

  Log Message:
  -----------
  Merge pull request #215 from m-lab/master

Bring in bugfixes from MLab


Compare: 
https://github.com/ndt-project/ndt/compare/93976a3aeea9...647452036fad