NDT-DEV email list created

Comment by 
:

General Comment:
I would separate out the MSG_LOGIN handling from the MSG_EXTENDED_LOGIN  
handling to make it easier to see what's happening. Beyond that,

+    if (msgLen > 1) {
+      log_println(0, "msgLen: %d-\n", msgLen);
+      log_println(0, "msgValue: %s-\n", msgValue + 1);
+      memcpy(options->client_version, msgValue + 1, msgLen-1);
+      log_println(0, "Client version: %s-\n", options->client_version);
+    }

I'd ensure that client_version is null terminated, and only print it out  
after that (i.e. ditch the msgValue stuff).

For more information:
https://code.google.com/p/ndt/source/detail?r=1046