Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Comment on revision r1046 in ndt

Subject: NDT-DEV email list created

List archive

[ndt-dev] Comment on revision r1046 in ndt

Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Comment on revision r1046 in ndt
  • Date: Thu, 03 Apr 2014 17:45:47 +0000

Comment by

General Comment:
I would separate out the MSG_LOGIN handling from the MSG_EXTENDED_LOGIN handling to make it easier to see what's happening. Beyond that,

+ if (msgLen > 1) {
+ log_println(0, "msgLen: %d-\n", msgLen);
+ log_println(0, "msgValue: %s-\n", msgValue + 1);
+ memcpy(options->client_version, msgValue + 1, msgLen-1);
+ log_println(0, "Client version: %s-\n", options->client_version);
+ }

I'd ensure that client_version is null terminated, and only print it out after that (i.e. ditch the msgValue stuff).

For more information:

Archive powered by MHonArc 2.6.16.

Top of Page