Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Re: Comment on revision r1046 in ndt

Subject: NDT-DEV email list created

List archive

[ndt-dev] Re: Comment on revision r1046 in ndt


Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Re: Comment on revision r1046 in ndt
  • Date: Thu, 03 Apr 2014 17:54:03 +0000

Comment by
:

General Comment:
Thanks, Aaron! Yes, I will separate the handling of the two. That was the way I had it first, but then I combined them to eliminate copy/paste. However, on second thought, I now realize the value of readability over that.

client_version will always be null terminated (should be) because it has 33 bytes whereas the max of that field in the protocol is 32 and the rcv_msg is limited to returning that much data.

That said, the log_println() call there is for debugging only and I will remove it before the final commit :-)

Thanks for your prompt review!

For more information:
https://code.google.com/p/ndt/source/detail?r=1046



Archive powered by MHonArc 2.6.16.

Top of Page