NDT-DEV email list created

[Kavitha Kumar <>]

Hi Dominic,

  This one addresses my questions, thanks! Here're my remaining questions:
1. NDTConstants.java:
We need to maintain EIGHT as a "double". This helps stop overflow leading to 
negative test results. So your change to this line 
will have to be backed off.
  public static final double EIGHT = 8.0; // Used in octal number, 
conversions from
-                                                                             
  // Bytes-> bits etc
+       public static final int EIGHT = 8; // Used in octal number, 
conversions from Bytes-> bits etc

2. Tcpbw100.java:

You assigned applet._sClient to args[0], which is the server hostname. If 
this was intentional, please add a comment as to why you assign it to the 
host name by default.

thanks,
Kavitha
                
----- Original Message -----
> From: "Dominic Hamon" 
> <>
> To: 
> 
> Sent: Wednesday, October 24, 2012 3:10:25 PM
> Subject: [ndt-dev] Re: M-Lab metadata patch
> 
> I've updated the patch as there were some merge issues with the last
> one.
> 
> 
> 
> 
> 
> 
> 
> On Wed, Oct 24, 2012 at 9:34 AM, Dominic Hamon < 
> 
>  >
> wrote:
> 
> 
> Hello
> 
> 
> As discussed previously, we have a patch that we use to identify
> clients running NDT against M-Lab servers. I'd like to get this
> patch into trunk so that we can stop maintaining our own branch and
> encourage developers to use the trunk version of NDT when building
> tools to run on M-Lab.
> 
> 
> I've attached the patch here and would appreciate your opinion.
> 
> 
> This patch has been rebuilt from a branch that was behind trunk by
> some way, so it's possible that there are some errors. I have built
> and tested locally, however, and did not spot anything obvious.
> 
> 
> 
> 
> 
> 
> - dominic
> 
>