Grouper Developers Forum

[Tom Zeller <>]

Weird. I thought there was a unit test for this case.

On Fri, Jun 14, 2013 at 9:59 AM, Shilen Patel 
<>
 wrote:
> The change log has never had subjectName on a membership delete entry.  We
> can add it there or the PSP can get the subject's name (assuming the
> subject is a group) from point in time.
>
> Thanks!
>
> -- Shilen
>
> On 6/14/13 9:42 AM, "Tom Zeller" 
> <>
>  wrote:
>
>>As you said, the changeLogMembershipGroupSubjectName attribute is
>>dependent on the 'subjectName' property of the deleteMembership
>>changelog entry, and that property is just not there, but 'subjectId'
>>is, so, the name of the member group will need to be returned by
>>querying grouper by subjectId, based on what I am seeing now. Querying
>>grouper for a group after it has been deleted is something I avoided.
>>
>>I don't think changelog entry properties have changed since last year,
>>but I am not sure.
>>
>>Tim, re-reading this thread you have spent some time on this, thank you.
>>
>>On Fri, Jun 14, 2013 at 8:12 AM, Tim Darby 
>><>
>>wrote:
>>> Attached is the log of an earlier test I did and here's the relevant
>>> grouper_change_log_entry_v entry for that test:
>>>
>>> 1369149651492000 membership
>>> deleteMembership     2850597
>>> id
>>> 2ca50db480f1436bb99514807c4cce49
>>> fieldName
>>> members
>>> subjectId
>>> bbd73751adab40dcb468e7a4800d064d
>>> sourceId
>>> g:gsa
>>> membershipType
>>> flattened
>>> groupId
>>> 5e4b3300d9f645cbab80d486a8f6c211
>>> groupName
>>> arizona.edu:services:enterprise:psptest:rollup
>>> memberId
>>> ce1a658faa01476faa5943f24bb3623d
>>> fieldId
>>> 43821411e6dc43f692acaab58e03e3ad
>>>
>>>
>>>
>>>
>>>
>>>
>>> 986f14c7ee8f47a6b1761c70a71c6d2c
>>> ae76dd8c6e9648399a973de9f058e021
>>>
>>> Tim Darby
>>> The University of Arizona
>>> Mosaic, Systems Integration and Architecture
>>> 
>>> UITS, Rm 335, 520-626-3799
>>>
>>>
>>> On Fri, Jun 14, 2013 at 6:00 AM, Tom Zeller 
>>> <>
>>>wrote:
>>>>
>>>> Could you run your test and reply with logs please ?
>>>>
>>>> You'll need the psp log level set to debug. I am interested in the
>>>> deleteMembership changelog entry log lines.
>>>>
>>>> On Thu, Jun 13, 2013 at 11:16 PM, Tim Darby 
>>>> <>
>>>> wrote:
>>>> > The order is 3 privilege types, then deleteMembership, and lastly
>>>> > deleteGroup.
>>>> >
>>>> > Tim Darby
>>>> > The University of Arizona
>>>> > Mosaic, Systems Integration and Architecture
>>>> > 
>>>> > UITS, Rm 335, 520-626-3799
>>>> >
>>>> >
>>>> > On Thu, Jun 13, 2013 at 7:58 PM, Tom Zeller 
>>>> > <>
>>>> > wrote:
>>>> >>
>>>> >> Moving to grouper-dev.
>>>> >>
>>>> >> When a member group is deleted and the 5 change log entries are
>>>> >> created, is the deletion of the member group first or last ?
>>>> >>
>>>> >> In any case, the name of the member group being deleted *should* be
>>>> >> presented as the 'subjectName' of the deleteMembership changelog
>>>> >> entry.
>>>> >>
>>>> >> On Thu, Jun 13, 2013 at 4:16 PM, Tim Darby
>>>><>
>>>> >> wrote:
>>>> >> > Any thoughts on this?
>>>> >> >
>>>> >> > On Tue, Jun 4, 2013 at 2:22 PM, Tim Darby
>>>><>
>>>> >> > wrote:
>>>> >> >>
>>>> >> >> I've looked into this a bit deeper and tell me if this makes any
>>>> >> >> sense:
>>>> >> >>
>>>> >> >> - I delete a group that is a member of another group.
>>>> >> >> - This creates a change log temp entry which grouper daemon
>>>>converts
>>>> >> >> into
>>>> >> >> 5 change log entries.
>>>> >> >> - When psp hits the change log entry for deleteMembership, what
>>>>it
>>>> >> >> needs
>>>> >> >> at that point is the group name of the member group, however that
>>>> >> >> name
>>>> >> >> appears nowhere in the change log entries.
>>>> >> >>
>>>> >> >> So how can it get the name?
>>>> >> >>
>>>> >> >> As far as I can tell there are only two places that name still
>>>> >> >> exists
>>>> >> >> at
>>>> >> >> that point - the grouper_members table and the grouper_pit_groups
>>>> >> >> table.  Is
>>>> >> >> there PSP resolver code that will get at those tables?  Or is
>>>>there
>>>> >> >> another
>>>> >> >> way to get that group name that I'm completely missing?
>>>> >> >>
>>>> >> >> On Thu, May 23, 2013 at 9:41 AM, Tim Darby
>>>> >> >> <>
>>>> >> >> wrote:
>>>> >> >>>
>>>> >> >>> Thanks, Tom, that makes a lot of sense.  Could this be the
>>>>issue?
>>>> >> >>> My
>>>> >> >>> config tries to calculate hasMember for a group using this code
>>>>in
>>>> >> >>> psp-resolver:
>>>> >> >>>
>>>> >> >>>   <!-- The value of the "changeLogMembershipGroupSubjectName"
>>>> >> >>> attribute
>>>> >> >>> is the name of the group member of a membership change
>>>> >> >>>     log entry. -->
>>>> >> >>>   <resolver:AttributeDefinition
>>>> >> >>>     id="changeLogMembershipGroupSubjectName"
>>>> >> >>>     xsi:type="ad:Script">
>>>> >> >>>     <resolver:Dependency
>>>>ref="AddMembershipChangeLogDataConnector"
>>>> >> >>> />
>>>> >> >>>     <resolver:Dependency
>>>> >> >>> ref="DeleteMembershipChangeLogDataConnector"
>>>> >> >>> />
>>>> >> >>>     <ad:Script><![CDATA[
>>>> >> >>>         // Import Shibboleth attribute provider.
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>>importPackage(Packages.edu.internet2.middleware.shibboleth.common.attrib
>>>>ute.provider);
>>>> >> >>>
>>>> >> >>>         // Create the attribute to be returned.
>>>> >> >>>         changeLogMembershipGroupSubjectName = new
>>>> >> >>> BasicAttribute("changeLogMembershipGroupSubjectName");
>>>> >> >>>
>>>> >> >>>         // Return 'subjectName' attribute values if the
>>>>'sourceId'
>>>> >> >>> attribute is 'g:gsa'.
>>>> >> >>>         if (typeof sourceId != "undefined" && sourceId != null
>>>>){
>>>> >> >>>             if (sourceId.getValues().contains("g:gsa")) {
>>>> >> >>>                 if (typeof subjectName != "undefined" &&
>>>> >> >>> subjectName
>>>> >> >>> !=
>>>> >> >>> null ){
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>>changeLogMembershipGroupSubjectName.getValues().add(subjectName.getValue
>>>>s().get(0));
>>>> >> >>>                 }
>>>> >> >>>             }
>>>> >> >>>         }
>>>> >> >>>     ]]></ad:Script>
>>>> >> >>>   </resolver:AttributeDefinition>
>>>> >> >>>
>>>> >> >>> Would this fail if the the member group is deleted before PSP
>>>>tries
>>>> >> >>> to
>>>> >> >>> process deleteMembership?
>>>> >
>>>> >
>>>
>>>
>