Grouper Developers Forum

[Shilen Patel <>]

Looks good.  I'm just noticing a couple of thing potential (minor) issues.

1.  There are locations in GrouperSourceAdapter.java and Group.java that seem to be converting SourceUnavailableException to SubjectNotFoundException for some reason.  The grouper db would probably have to be down to run into this issue, but it still doesn't seem right.

2.  Regarding your comment about the init during startup, it seems like the jdbc source doesn't actually create a connection during init so Grouper may still start up if the source is unavailable.

Thanks!

-- Shilen

On 3/16/11 11:23 PM, Chris Hyzer wrote:

Good “catch”.  Ok, fixed that, and looked at other methods in jdbc2 and made another tweak, check it out J

 

Thanks,

Chris

 

From: [] On Behalf Of Shilen Patel
Sent: Wednesday, March 16, 2011 5:19 PM
To: Chris Hyzer
Cc: Emily Eisbruch; Tom Barton;
Subject: Re: [grouper-dev] RE: Source Not Available, JIRA 570

 

Hi Chris,

JDBCSourceAdapter.uniqueSearch() still seems to be swallowing SQLExeptions, which leads to a SubjectNotFoundException, right?  I haven't looked at JDBCSourceAdapter2 yet (will do tomorrow) but that might have the same issue.   And I haven't found any issues with JNDISourceAdapter.

Thanks!

-- Shilen

On 3/16/11 3:42 PM, Chris Hyzer wrote:

This is fixed in 2.0.  Shilen, do you mind looking at what I did in my commit to trunk and seeing if it is ok and if I missed anything? J  I do have a test case, though this kind of stuff is hard to unit test completely.

 

https://bugs.internet2.edu/jira/browse/GRP-570

 

1. If a source is unavailable on grouper startup, I think Grouper will not start. This is because sources need to be initted, and before this fix the source will just not be there ever, which is very confusing.

 

2. If a findAll (general search) happens, and there is an exception, this will be converted to a SourceUnavailable exception instead of being swallowed

 

3. If you set the sources.xml setting of:

 

     You can flag a source as not throwing exception on a findAll (general search) i.e. if it is ok if it is down. Generally you probably won't want to do this. It defaults to true if omitted.

 

     <init-param>

       <param-name>throwErrorOnFindAllFailure</param-name>

       <param-value>false</param-value>

     </init-param>

 

Thanks,

Chris

 

From: Emily Eisbruch []
Sent: Wednesday, March 16, 2011 12:59 PM
To: Chris Hyzer
Cc: Tom Barton
Subject: Source Not Available, JIRA 570

 

Hi Chris,

 

On the Grouper Call today after you left, TomB inquired about the status of this issue from the 3-March call :

source not available should not throw subject not found

https://bugs.internet2.edu/jira/browse/GRP-570

 

TomB asked me to ping you to ask if you are working on this.....  he feels it really needs to be addressed.

 

Thanks,

Emily

 

 

https://bugs.internet2.edu/jira/browse/GRP-570

Emily Eisbruch, Technology Transfer Analyst

Internet2

office: +1-734-352-4996 | mobile +1-734-730-5749

 

Visit our website: www.internet2.edu
Follow us on Twitter: www.twitter.com/internet2
Become a Fan on Facebook: www.internet2.edu/facebook