Grouper Developers Forum

[Chris Hyzer <>]

No prob, I didn't commit that import...  if we want to add more types, just 
let me know

Thanks,
Chris



-----Original Message-----
From: 

 
[mailto:]
 On Behalf Of Erik Froese
Sent: Friday, March 11, 2011 12:09 PM
To: Chris Hyzer
Cc: 

Subject: Re: [grouper-dev] Supporting GROUP_ADD and GROUP_DELETE in the 
grouperClient XMPP

Hey Chris,

An import statement snuck in there too. Sorry about that.

https://github.com/efroese/grouper-client/blob/9e452d053d170860540074a7047193112add4b7b/src/extMore/edu/internet2/middleware/grouperClientExt/xmpp/GrouperClientXmppMain.java#L35

I restricted the event types because I ran into some errors with the
GROUP_ADD and GROUP_DELETE types. As I move forward I'll test more of
the types and verify that they work and add them to the list of
accepted types. Sound reasonable?

Erik

On Fri, Mar 11, 2011 at 11:52 AM, Chris Hyzer 
<>
 wrote:
> Hey,
>
> Thanks a lot for making a patch and sending it back.  I wonder if we should 
> restrict event types at all... hmmm (e.g. stem add, privilege revoke, etc). 
>  Anyways, I didn't want to add a new Jar, so I changed your immutable set 
> to this:
>
> Collections.unmodifiableSet(GrouperClientUtils.toSet("MEMBERSHIP_ADD"...
>
> Take a look at this once it shows up there (I think there is some lag), and 
> diff the versions and see if you think it will work.
>
> http://anonsvn.internet2.edu/cgi-bin/viewvc.cgi/i2mi/trunk/grouper-misc/grouperClient/src/extMore/edu/internet2/middleware/grouperClientExt/xmpp/GrouperClientXmppMain.java?view=log
>
> Thanks,
> Chris
>
>
> -----Original Message-----
> From: 
> 
>  
> [mailto:]
>  On Behalf Of Erik Froese
> Sent: Friday, March 11, 2011 10:30 AM
> To: 
> 
> Subject: [grouper-dev] Supporting GROUP_ADD and GROUP_DELETE in the 
> grouperClient XMPP
>
> Hey everyone,
>
> I've been working with the XMPP code in the grouperClient project and
> I came up with a patch that helps me out a bit. I've put the
> grouperClient project in my github account so I can work with more
> easily.
>
> https://github.com/efroese/grouper-client/commit/9e452d053d170860540074a7047193112add4b7b
>
> From what I can see the client code was written with the
> MEMBERSHIP_ADD and MEMBERSHIP_DELETE events in mind. For each event
> received the GrouperClientXmppMain tries to fetch the membership for
> the group listed in the event. Unfortunately for groups that are in
> the process of being created or have just been deleted this call
> throws an error.
>
> I've added a list of currently supported events SUPPORTED_EVENT_TYPES
> and a check in the incrementalRefreshGroup method.
>
> WDYT?
>
> Erik3
>