COmanage Developers List

[Marie Huynh <>]

Hi Benn,

Can you take a look at this when you get the chance?

Thanks,

Marie

On Wed, Nov 16, 2011 at 5:57 PM, Marie Huynh 
<>
 wrote:
>>
>>> M       trunk/app/models/co_person.php
>>
>>
>> The logic in your foreach loop looks very similar to
>> libs/util.php:generateCn(). Perhaps you should update and use that 
>> function?
>
> Why was the honorific field ignored in generateCn?
>
>>
>>> M       trunk/app/config/schema/schema.xml
>>
>>
>> Why is there a second index created on co_person_id?
>>
>
> I could have sworn it was sponsor_co_person_id; it seemed like you had
> an index for all the other foreign keys so I threw that one in too.
> Does it make sense if there are two foreign keys to the same table?
>
>>
>> Why is $sponsors set in both co_person_roles_controller and
>> co_people_controller?
>
> It's used for the views of both of these so need to be set in both 
> controllers:
> gears/co_people/edit/1/co:1 (to display name of Sponsor)
> gears/co_person_roles/edit/4/co:1 (to feed into dropdown for Sponsor 
> selection)
>
> I checked and there's only one instance of [sponsors] in $this.
>
>>
>>> A       trunk/app/models/demographic.php
>>
>> Note your new files ('A') aren't included in the diff.
>>
>
> right, forgot the --diff-cmd diff.  There's a lot of copypasta and
> isn't done, but I attached the new diff.
>
>>> M       trunk/app/libs/enum.php
>>
>> I realize this is how the standard defines things, but it bothers me that 
>> we
>> have a 'RaceEnum'. I'd rather it be called 'EthnicityEnum', but that
>> apparently means something else. (This also goes for lang.php.) Can we
>> change the names in the code and just use the terms 'Ethnicity' and 'Race'
>> in the actual display (ie: translated) text?
>>
>> Something like
>>
>>  class HispanicEnum
>>  {
>>   const Hispanic = "H";
>>   const NotHispanic = "H";   <-- note not NotHis
>>  }
>>
>>  class EthnicityEnum
>>  {
>>   Asian
>>   AmericanIndian    <-- any reason not to spell these out?
>>   Black
>>   NativeHawaiian
>>   White
>>  }
>>
>>  // These might even only be defined this way in the LIGO installation
>>  fd.de.hispanic => "Ethinicity"
>>  fd.de.ethnicity => "Race"
>>
>
> I don't like the way these standards define these either, but I'd
> rather follow some other standard if we're going to deviate from this
> one.  If we're going to be swapping race and ethnicity around, I
> rather we not use fd.de.ethnicity at all and name it something else.
> What users are you expecting to have and what sort of modifications do
> you think they'll need?
>