Shibboleth Developers

[Brent Putman <>]

On 9/26/10 11:56 PM, Bradley Schwoerer wrote:
> I thought I would ask on here before I go about doing a fair amount of
> work that others have already embarked upon.  Has anyone
> attempted/succeeded getting the idp-ext-delegation stuff working against
> the 2.2.0 idp?  I have a start where I compiled it against the 2.2.0 idp
> with the new org.slf4j.Logger.  Attached are the changes to make it
> compile and a starting point for others.  I am going to continue on this.


Thanks for the info.

I haven't tested it against 2.2 yet, but aside from the slf4j
MessageFormatter changes you found, I can't off-hand think of anything
major that requires updating.  In general extensions written against the
2.1 API ought to work just fine in 2.2.  But there might be some
unintentional behavioral changes that need to be addressed.

BTW, for the record, there's a slight error in your patch.  I had to
double-check this b/c I never use the java.text.MessageFormat. The
positional args have to contain the numeric index of the array arg.
Also things in single quotes have to be double single-quoted, or else
the formatting is skipped. Leaving out the numeric index, causes a
run-time error, and not doing the quoting properly just silently fails
to format.


So instead of this:

MessageFormat.format("Hello '{}'", name);

you instead need this:

MessageFormat.format("Hello ''{0}''", name);


Another option would be to use the java.util.Formatter instead.

Don't worry about re-doing the patch, I'll fix the delegation project up
in the next couple of days.



> 
> Maybe these are the only changes necessary.  Any thoughts from people
> more knowledgeable than I.   Should I open a bug in Jira to track this?  
> 



We actually don't have a Jira project for the extensions at the moment.
 We haven't ever really addressed the notion of issue tracking for
extensions, even "official" ones produced by the core team.  For now
just post to this list.  If we figure out a solution for issue-tracking
vis-a-vis extensions, we'll announce something to the list.

Thanks,
Brent