Shibboleth Developers

["Howard Gilbert" <>]

> Totally agree.  Howard, would you prefer to merge your stuff in here or
> just delete this method?

Currently the Origin version of this code only uses the prepare method, and
the SP version only uses the accept method. Clearly there should not be two
classes with two methods in different packages. It remains to be seen,
however, whether to create one merged class by merging the two versions of
the accept() method or to create two classes with one method each. There is
really no reason for the IdP and SP functions to be in the same class just
because they deal with two ends of the same process.

I will put this on the list of things to clean up, and personally I vote for
deleting one method in one class, the other method in the other class.


> 
> 
> >> The IdP only uses the "prepare" end of the POST profile class.  I
> >> believe that the currently-under-development Java SP implementation
> >> uses a completely separate class for this functionality.
> >
> > Seems like we should probably either *use* that class, suitably fixed,
> > in
> > the Java SP, or redo the APIs. It's confusing to have dead code lying
> > around.