Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] patches for the HTML5-frontend ?

Please Wait...

ndt-dev@internet2.edu

Subject: NDT-DEV email list created

List archive

[ndt-dev] patches for the HTML5-frontend ?


Chronological Thread 
  • From: Athanasios Douitsis <aduitsis@gmail.com>
  • To: ndt-dev@internet2.edu
  • Cc: Angela Dimitriou <angela@noc.ntua.gr>
  • Subject: [ndt-dev] patches for the HTML5-frontend ?
  • Date: Wed, 21 Oct 2015 18:06:16 +0300

Hello,

In case one desires to submit a small patch (e.g. for the ndt-browser-client.js) under HTML5-frontend, would a pull request on https://github.com/ndt-project/ndt be appropriate?

I have run across an mlab ndt server that for some reason does not respond normally to the websocket version of the protocol. While this sounds bad, it actually gave me the opportunity to realize that, upon creation of the websocket in ndt-browser-client.js, the onclose and onerror events are not handled, so if the connection is dropped abnormally or any other sort of error occurs, the application using NDTjs doesn't learn it and can hang in there indefinitely.

If I may be permitted, I'd like to submit a small patch to fix that.

Also, another question, in my tests I am using Workers under Firefox quite successfully. It seems that the bug saying that WebSockets were not available in Workers (*) is nowadays fixed. Anyone aware whether there is any issue concerning the accuracy of measurements? Because as far as I can tell it works beautifully.

(*) https://bugzilla.mozilla.org/show_bug.cgi?id=504553

Thanks,
--
Athanasios Douitsis





Archive powered by MHonArc 2.6.16.

Top of Page