Skip to Content.
Sympa Menu

ndt-dev - Re: [ndt-dev] Advice in resolving issue #102

Subject: NDT-DEV email list created

List archive

Re: [ndt-dev] Advice in resolving issue #102


Chronological Thread 
  • From: Aaron Brown <>
  • To: Jakub Sławiński <>
  • Cc: "" <>
  • Subject: Re: [ndt-dev] Advice in resolving issue #102
  • Date: Wed, 12 Feb 2014 15:19:02 +0000
  • Accept-language: en-US

Hey Jakub,

#1 seems the path of least resistance so I’d support going that route for now.

Cheers,
Aaron

On Feb 12, 2014, at 3:45 AM, Jakub Sławiński
<>
wrote:

>
> Hi Sebastian,
>
> Issue #102 is about handling 9977 on the Java side, so adding this check
> should be enough to close this ticket.
>
> The comments in this issue are about other inconsistencies between
> different implementations and specification, but there was no decision
> about what to do with them.
>
> We have two possible ways of resolving Issue #102 and related
> inconsistencies:
>
> 1.
> a) handle 9977 on the Java side and close #102
> b) agree on the mailing list about which statuses should be used in
> which cases
> c) Create appropriate issue(s) to implement the proposed changes
>
> 2.
> a) agree on the mailing list about which statuses should be used in
> which cases
> b) update the Issue #102 title/description with the proposed changes
> c) implement the proposed changes and close #102
>
> I would personally suggests the first option, but Aaron should decide
> which way to go.
>
>
> Regards,
> Jakub.
>
> On 02/11/2014 04:25 PM, Sebastian Malecki wrote:
>> Hi.
>> I've just try to resolve problem from issue #102. The main problem isn't
>> difficult, but I'm not sure what to do with Jakub suggestion
>> (https://code.google.com/p/ndt/issues/detail?id=102#c1).
>>
>> 1.
>> Do we need "SRV_QUEUE_SERVER_BUSY_60s", which is only implemented in
>> clients,
>> but it's never send by server. It's even not in documentation
>> (https://code.google.com/p/ndt/wiki/NDTProtocol#Queuing_clients).
>> Please let me know if I understand because "Server Busy: Please wait 60
>> seconds for previous test to finish" is not precise enough for me. Busy_60s
>> should be send if server drop the connection and client try connect faster
>> than 60s? Only after "9988" message or also after "9977"?
>>
>> 2.
>> And question about: SRV_QUEUE_SERVER_FAULT. In most places server send 9988
>> (SRV_QUEUE_SERVER_BUSY), but in my opinion it should be send only from:
>> https://code.google.com/p/ndt/source/browse/trunk/src/web100srv.c#2291,
>> right?
>>
>> In my opinion "9977" should be send from:
>> https://code.google.com/p/ndt/source/browse/trunk/src/web100srv.c#2030
>> https://code.google.com/p/ndt/source/browse/trunk/src/web100srv.c#2049 (as
>> in
>> the command)
>> https://code.google.com/p/ndt/source/browse/trunk/src/web100srv.c#2083
>>
>




Archive powered by MHonArc 2.6.16.

Top of Page