Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Issue 72 in ndt: Review Request: update NDT Android app to use mlab-ns server discovery

Subject: NDT-DEV email list created

List archive

[ndt-dev] Issue 72 in ndt: Review Request: update NDT Android app to use mlab-ns server discovery


Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Issue 72 in ndt: Review Request: update NDT Android app to use mlab-ns server discovery
  • Date: Tue, 15 Jan 2013 22:28:44 +0000

Status: New
Owner:

CC:

Labels: Type-Review Severity-Medium

New issue 72 by : Review Request: update NDT Android app to use mlab-ns server discovery
http://code.google.com/p/ndt/issues/detail?id=72

Purpose of code changes on this branch:

Remove references to DONAR and perform server discovery using mlab-ns. Mlab-ns uses a more robust server-liveness mechanism, and should return better servers for test runs.

When reviewing my code changes, please focus on:

Android/AndroidManifest.xml
* updated versionCode & versionName
* moved uses-sdk and uses-permissions before application element to avoid compiler warnings

Android/res/values/strings.xml
* update app_name
+ add user_agent and default_user_agent for use by MLabNS.java

Android/src/net/measurementlab/ndt/MLabNS.java
+ add new file and class for interacting with MLabNS service

Android/src/net/measurementlab/ndt/SelectServerActivity.java
+ add lookupHostname() to call MLabNS.Lookup() with reference to the existing list of M-Lab sites.
* update SERVER_LIST to use metro codes to pass directly to MLabNS.Lookup()

Android/src/net/measurementlab/ndt/InitialActivity.java
* uses lookupHostname() for initial servername.
Android/src/net/measurementlab/ndt/NdtService.java
* uses lookupHostname() for default servernames.
Android/src/net/measurementlab/ndt/TestsActivity.java
* uses lookupHostname() for default servernames.

java/net/measurementlab/ndt/NdtTests.java
* invokes Thread.sleep() according to current documentation.

After the review, I'll merge this branch into:
/svn/branches/android



Attachments:
update-1.0b4.patch 18.9 KB




Archive powered by MHonArc 2.6.16.

Top of Page