OpenSAML user discussion

[Brent Putman <>]

Hmm, yeah, IMHO, I think this is a bug and it should probably throw an 
exception (probably of a new type, b/c we don't have an immediately 
obvious appropriate one).  I'll confer with Chad, b/c this will change 
the API substantially and calling code (ours and other people's) would 
have to change to handle.  But that seems the right thing to do.



 wrote:
> Hi - 
>    I was running some tests and noticed that my SAML output was incorrect.  I was able to resolve my issue, but was curious as to why code execution continued in a error state.  
> Checking the logs, I saw an error regarding the signature process in org.opensaml.xml.signature.Signer.signObject.  From looking at the source, I noticed this code just writes the error to the log instead of throwing an exception to the caller:
>
> lines 77-79 of org.opensaml.xml.signature.Signer.signObject:
>         } catch (XMLSecurityException e) {
>             log.error("An error occured computing the digital signature", e);
>         }
>
> Is this behavior intentional?  It seems a bit odd to not alert the caller of 
> a critical error...
>
> Thanks!
> Dave
>