Grouper Users - Open Discussion List

["Black, Carey M." <>]

Akki,

 

A few comments that I hope will help you understand the approach that the Grouper project uses.

 

REF: https://spaces.internet2.edu/display/Grouper/Grouper+developers+coding+standards

REF: https://spaces.internet2.edu/display/Grouper/Grouper+patching

 

To the best of my knowledge:

 

1)      Master is a bleeding edge DEV branch.

a.       Release branches (AKA: GROUPER_2_3_0 ) are stable. AKA: patches are not applied here. Last commit 972bcf6  on Apr 16, 2016 ( I do not understand that reasoning, but that is my understanding.)

b.       Other branches (AKA: GROUPER_2_3 ) are dev/stable.  AKA: Patches are developed here. Latest commit 2f9ab62  5 days ago.  So only the commits that are “tested later” and are found to be “good to use” would be “ok” to use. (And you will likely not know which commits are good or not.)

                                                               i.      I think the Grouper Dev team uses this branch to make the “patches” (maybe by ref from the GROUPER_2_3_0  branch? I could be wrong about those details. I am guessing more than a bit. ) that are then uploaded somewhere else (internet2 web server?) for the Grouper Install to pull down.

 

2)      There is a Java program (Grouper Installer) that is designed to download individual patches and “layer them on top of an existing install directory”.

a.       NOTE: This is a “binary” patch, not a source code patch.  (Well, kind of. Actually, it is complicated. J )

b.       These patches might also do things like alter your RDBMS structures/data too.

c.       By design, if the patch finds an existing file that has been altered from the default then it will keep a copy of the altered original file. Then applies the patch. ( The task of the merge is left to you after the patch is applied.)

d.       This installer can be run in an “auto patch” mode too: REF https://spaces.internet2.edu/display/Grouper/Grouper+installer+non+interactive+auto+apply+patches+example

 

Hope that helps.

 

--

Carey Matthew

 

From: [mailto:] On Behalf Of Akki Kumar
Sent: Monday, July 31, 2017 12:00 PM
To: Hyzer, Chris <>
Cc:
Subject: [grouper-users] Re: URGENT: API Patch#42 Missing from Master Branch

 

That sound like a good plan. J Where can I find the automated script that will download all patches and apply it to the source code? (Or is there automated script?)

 

Thank you,

Akki

 

On Mon, Jul 31, 2017 at 11:40 AM, Hyzer, Chris <> wrote:

Yes, but also contains development work not ready for use J

 

You could get GROUPER_2_3_0 and patch it with patches and that would work J

 

From: Akki Kumar [mailto:]
Sent: Monday, July 31, 2017 11:27 AM
To: Hyzer, Chris <>
Cc:
Subject: Re: URGENT: API Patch#42 Missing from Master Branch

 

Hi Chris,

 

Thank you for the prompt reply. So, all 2.3.0 patches source code pushed to the GROUPER_2_3_BRANCH? Does the GROUPER_2_3_BRANCH contain all the patches? 

 

 

- Akki

 

 

On Mon, Jul 31, 2017 at 10:40 AM, Hyzer, Chris <> wrote:

I cherry picked that commit to master.

 

Why are you pulling source code from master?  You should not be pulling source code from github, you should be installing from tarballs and patches.  And you shouldn’t be using the master branch, you should be using the GROUPER_2_3_BRANCH.  But whats in github doesn’t mean its stable, it is stable in the tarballs and patches.  Ok?

 

Thanks

Chris

 

From: Akki Kumar [mailto:]
Sent: Monday, July 31, 2017 10:08 AM
To: Hyzer, Chris <>;
Subject: URGENT: API Patch#42 Missing from Master Branch

 

Hi Team Lead,

 

We are planning to update Grouper to version 2.3.0 (in Prod) this Thursday(8/3/17), but Grouper is throwing an error since last week. 

 

In our Grouper deployment process, we pulled out the source code from the Master branch (with all patches), build UI & WS Wars and deploy the Wars on the environment. Two weeks ago, we successfully updated the Dev environment to Grouper 2.3.0 (v) and the application ran fine (during a test with no error). However, last week I pulled out the source code from the Master branch, updated QA Environment to Grouper 2.3.0 (v), but the application was failing with below error:

   

 

ERROR GrouperLoaderJob.runJob(443) -  - Error on job: CHANGE_LOG_changeLogTempToChangeLog

edu.internet2.middleware.grouper.internal.dao.GrouperDAOException: Problem in HibernateSession: HibernateSession (3869c889): new, notReadonly, READ_WRITE_NEW, notActiveTransaction, session (2b6a8084)

   at edu.internet2.middleware.grouper.hibernate.HibernateSession._internal_hibernateSessionCatch(HibernateSession.java:604)

   at edu.internet2.middleware.grouper.hibernate.HibernateSession.callbackHibernateSession(HibernateSession.java:710)

   at edu.internet2.middleware.grouper.changeLog.ChangeLogTempToEntity.convertRecords(ChangeLogTempToEntity.java:100)

   at edu.internet2.middleware.grouper.app.loader.GrouperLoaderType$5.runJob(GrouperLoaderType.java:678)

   at edu.internet2.middleware.grouper.app.loader.GrouperLoaderJob.runJob(GrouperLoaderJob.java:423)

   at edu.internet2.middleware.grouper.app.loader.GrouperLoaderJob.execute(GrouperLoaderJob.java:323)

   at org.quartz.core.JobRunShell.run(JobRunShell.java:202)

   at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)

Caused by: java.lang.NoSuchMethodError: edu.internet2.middleware.grouper.hibernate.ByHqlStatic.executeUpdate()I

   at edu.internet2.middleware.grouper.internal.dao.hib3.Hib3PITGroupSetDAO.updateEndTimeByPITOwner(Hib3PITGroupSetDAO.java:239)

   at edu.internet2.middleware.grouper.changeLog.ChangeLogTempToEntity.processGroupDelete(ChangeLogTempToEntity.java:327)

   at edu.internet2.middleware.grouper.changeLog.ChangeLogTempToEntity.access$200(ChangeLogTempToEntity.java:63)

   at edu.internet2.middleware.grouper.changeLog.ChangeLogTempToEntity$1.callback(ChangeLogTempToEntity.java:114)

   at edu.internet2.middleware.grouper.hibernate.HibernateSession.callbackHibernateSession(HibernateSession.java:700)

After troubleshooting for a day, I found the source of the error i.e.  grouper_v2_3_0_api_patch_42 is missing from the Master branch. I have attached the screenshots to below link. Can someone please push the API Patch# 42 source code to the Master branch? (Also, is it possible to make sure other patches source code are pushed to the Master Branch?)

Screenshots: https://drive.google.com/open?id=0BwgGnZC7vA-6Rzc5Yktic3BIcHM

Master Branch: 

• ByHqlStatic: https://github.com/Internet2/grouper/blob/master/grouper/src/grouper/edu/internet2/middleware/grouper/hibernate/ByHqlStatic.java
• ByHql: https://github.com/Internet2/grouper/blob/master/grouper/src/grouper/edu/internet2/middleware/grouper/hibernate/ByHql.java

Grouper 2.3.0 Patches: http://software.internet2.edu/grouper/release/2.3.0/patches/

 

 

Thank you,

Akki