Grouper Users - Open Discussion List

["Hyzer, Chris" <>]

Chad, this is fixed in 2.3.0 patch 36.  Can you take a look or try it please?

Thanks for identifying the problem and providing the code for a fix.

https://bugs.internet2.edu/jira/browse/GRP-1433

Chris



-----Original Message-----
From: Chad Redman (JIRA) 
[mailto:]
 
Sent: Monday, December 05, 2016 10:44 AM
To: Hyzer, Chris 
<>
Subject: [JIRA] (GRP-1433) json in REST input disallows whitespace at end

Chad Redman created GRP-1433:
--------------------------------

             Summary: json in REST input disallows whitespace at end
                 Key: GRP-1433
                 URL: https://bugs.internet2.edu/jira/browse/GRP-1433
             Project: Grouper
          Issue Type: Improvement
          Components: WS
    Affects Versions: 2.3.0, 2.2.0, 2.1.0
            Reporter: Chad Redman
            Assignee: Chris Hyzer


When setting the POST json string for a REST request, the json format checker 
allows whitespace anywhere except at the end of the string. If the last 
character is not a closing brace, it throws error "Error unparsing string 
with converter: 
edu.internet2.middleware.grouper.ws.rest.json.DefaultJsonConverter...".

This sounds like a trivial issue, but it actually does make for confusing 
behavior when using something like SoapUI to develop. The stacktrace includes 
the input string, but with no quotes around it there is no indication whether 
or not final whitespace is even there. One must be careful when setting up 
the SoapUI request, making sure to delete any carriage return that might be 
there after the closing brace.


Fix:


{code:java}
diff --git 
a/grouper/src/grouper/edu/internet2/middleware/grouper/util/GrouperUtil.java 
b/grouper/src/grouper/edu/internet2/middleware/grouper/util/GrouperUtil.java
index eb8d254..c2e4a48 100644
--- 
a/grouper/src/grouper/edu/internet2/middleware/grouper/util/GrouperUtil.java
+++ 
b/grouper/src/grouper/edu/internet2/middleware/grouper/util/GrouperUtil.java
@@ -1715,12 +1715,12 @@ public class GrouperUtil {
    * \{\s*         open bracket and optional space
    * \"([^"]+)\"   quote, simple name of class, quote
    * \s*:\s*       optional space, colon, optional space
-   * \{(.*)}$      open bracket, the class info, close bracket, end of string
+   * \{(.*)}\s*$      open bracket, the class info, close bracket, optional 
space, end of string
    *
    *
    * </pre>
    */
-  private static Pattern jsonPattern = 
Pattern.compile("^\\s*\\{\\s*\\\"([^\"]+)\\\"\\s*:\\s*(.*)}$", 
Pattern.DOTALL);
+  private static Pattern jsonPattern = 
Pattern.compile("^\\s*\\{\\s*\\\"([^\"]+)\\\"\\s*:\\s*(.*)}\\s*$", 
Pattern.DOTALL);

   /**
    * convert an object from json.  note this works well if there are no 
collections, just real types, arrays, etc.


{code}




--
This message was sent by Atlassian JIRA
(v6.4.11#64026)