grouper-users - Re: [grouper-users] words/sentences directly in english in some JSP files

Subject: Grouper Users - Open Discussion List

List archive

Re: [grouper-users] words/sentences directly in english in some JSP files

From: Yoann Delattre <>
To: Chris Hyzer <>, "" <>
Subject: Re: [grouper-users] words/sentences directly in english in some JSP files
Date: Wed, 19 Nov 2014 14:49:02 +0100

no problem !
thanks for the quick fix :)

Yoann.

Le 17/11/2014 22:20, Chris Hyzer a écrit :

Sorry about that, it’s fixed:

https://bugs.internet2.edu/jira/browse/GRP-1082

https://github.com/Internet2/grouper/commit/6702dd031fb169da098ab101c9f28ac6a2f4fd1a

Thanks,

Chris

From: Yoann Delattre []
Sent: Monday, November 17, 2014 5:19 AM
To: Chris Hyzer;
Subject: Re: [grouper-users] words/sentences directly in english in some JSP files

Hi,

yep, it fix the problem. thanks a lot :)

just one last text not externalized :

GrouperPagingTag2.java line 251 ---> result.append(" <label for="\"show-entries\">Show: </label>\n");

thanks again !
Yoann.
Le 08/11/2014 14:48, Chris Hyzer a écrit :

I think this will fix your problem

https://github.com/Internet2/grouper/commit/08bbeeed9c37353e4c781a059d712d622c792fba

Note, I will also commit some changes to make more encodings configurable…

Thanks,

Chris

From: Yoann Delattre []
Sent: Friday, November 07, 2014 2:52 AM
To: Chris Hyzer;
Subject: Re: [grouper-users] words/sentences directly in english in some JSP files

Thanks a lot :)

Just finish to test.
Still have a problem with paging tag : it's in english.

my grouper.text.en.us.base.properties

########################################
############## Paging Tag 2nd edition
########################################

# paging 2 tag, showing label
paging2.showing = Showing

# of link in paging 2 tag
paging2.of = of

# First link of paging2
paging2.first = First

# Prev link of paging2
paging2.prev = Prev

# Next link of paging2
paging2.next = Next

# Last link of paging2
paging2.last = Last

my grouper.text.fr.fr.base.properties

########################################
############## Paging Tag 2nd edition
########################################

# paging 2 tag, showing label
paging2.showing = Page

# of link in paging 2 tag
paging2.of = /

# First link of paging2
paging2.first = Début

# Prev link of paging2
paging2.prev = Précédente

# Next link of paging2
paging2.next = Suivante

# Last link of paging2
paging2.last = Fin

result :

Do you want to try to keep the externalized French version in git? Is that something you can maintain for each release? J

I can try :), we still need to check some translation. But i think the externalized Fench version can be finish soon :)

Thanks a lot,
Yoann.

Le 04/11/2014 21:00, Chris Hyzer a écrit :

Thanks a lot for compiling this list.

Do you want to try to keep the externalized French version in git? Is that something you can maintain for each release? J

This is fixed. Note a lot of these were in JSP comments. Also found a couple more.

https://bugs.internet2.edu/jira/browse/GRP-1065

https://github.com/Internet2/grouper/commit/995233fc30e28756d06c45102e615858a6194467

https://github.com/Internet2/grouper/commit/6dcf79b62d9623d2b9f86bf5e2295aac5572eae7

If you have time, test it out and let me know J

Thanks,

Chris

From: [] On Behalf Of Yoann Delattre
Sent: Wednesday, October 15, 2014 9:39 AM
To:
Subject: [grouper-users] words/sentences directly in english in some JSP files

Hi everyone :)

i'm translating the NewUI in french, and i discovered some words/sentences directly in english in some JSP/Java files.

If it can help, this is what i found :

stemDelete.jsp

line 22

<div class="form-actions"><a href="#" class="btn btn-primary" >Delete</a>

line 23

<a href="#" class="btn btn-cancel" >Cancel</a></div>

GrouperPagingTag2.java

line 222

result.append(" <div class=\"pull-right\">Showing " + (queryPaging.getFirstIndexOnPage()+1) + "-" + (queryPaging.getLastIndexOnPage()+1) + " of " + this.guiPaging.getTotalRecordCount() + " · ");

line 229

result.append("First | Prev");

line 231

result.append("<a href="\"#\"" + _javascript_EventPrefix + this.refreshOperation + _javascript_EventSuffix + "\">First</a> | ");

line 233

+ appendToUrl(this.refreshOperation, "pagingTagPageNumber=" + (queryPaging.getPageNumber()-1) ) + _javascript_EventSuffix + "\">Prev</a>");

line 240

+ appendToUrl(this.refreshOperation, "pagingTagPageNumber=" + (queryPaging.getPageNumber()+1) ) + _javascript_EventSuffix + "\">Next</a>");

line 243

+ appendToUrl(this.refreshOperation, "pagingTagPageNumber=" + queryPaging.getNumberOfPages() ) + _javascript_EventSuffix + "\">Last</a>");

stemPrivilegeContents.jsp

line 10

<label for="people-update">Update:</label>

line 15

<option value="assign_creators">Assign the CREATE GROUP privilege</option>

line 16

<option value="assign_stemmers">Assign the CREATE FOLDER privilege</option>

line 17

<option value="assign_stemAttrReaders">Assign the ATTRIBUTE READ privilege</option>

line 18

<option value="assign_stemAttrUpdaters">Assign the ATTRIBUTE UPDATE privilege</option>

line 19

<option value="assign_all">Assign ALL privileges</option>

line 20

<option value="revoke_creators">Remove the CREATE GROUP privilege</option>

line 21

<option value="revoke_stemmers">Remove the CREATE FOLDER privilege</option>

line 22

<option value="revoke_stemAttrReaders">Remove the ATTRIBUTE READ privilege</option>

line 23

<option value="revoke_stemAttrUpdaters">Remove the ATTRIBUTE UPDATE privilege</option>

line 24

<option value="revoke_all">Remove ALL privileges</option>

line 40

<th class="sorted">Name</th>

line 41

<th data-hide="phone" style="white-space: nowrap; text-align: center;">Create folder</th>

line 42

<th data-hide="phone" style="white-space: nowrap; text-align: center;">Create group</th>

line 43

<th data-hide="phone" style="white-space: nowrap; text-align: center;">Attribute read</th>

line 44

<th data-hide="phone" style="white-space: nowrap; text-align: center;">Attribute update</th>

indexMyFavorites

line 3

<h4>My favorites</h4>

indexColumnMenu.jsp

line 9

<li class="nav-header">Select a widget to display</li>

line 11

<li><a href="#" >My favorites</a></li>

line 12

<li><a href="#" >Groups I manage</a></li>

line 13

<li><a href="#" >My services</a></li>

line 14

<li><a href="#" >My folders</a></li>

line 15

<li><a href="#" >My memberships</a></li>

line 16

<li><a href="#" >Recently used</a></li>

indexStemsImanage

line 3

<h4>My folders</h4>

index.jsp

line 75

<button type="button" class="btn btn-block btn-grouper last">Browse Folders</button>

stemMoreActionsButtonContents.jsp

line 16

<div class="btn-group btn-block"><a data-toggle="dropdown" href="#" class="btn btn-medium btn-block dropdown-toggle">More actions </a>

line 23

>Remove from my favorites</a></li>

line 28

>Add to my favorites</a></li>

subjectHeader.jsp

line 7

<li><a href="index.html">Home </a></li>

invite.jsp

line 9

<li><a href="index.html">Home </a></li>

stemHeader.jsp

line 6

<li><a href="index.html">Home </a></li>

newStem.jsp

line 5

<li><a href="#" >Home </a></li>

stemDelete.jsp

line 9

<li><a href="index.html">Home </a></li>

stemCopy.jsp

line 9

<li><a href="index.html">Home </a></li>

stemMove.jsp

line 9

<li><a href="index.html">Home </a></li>

newGroup.jsp

line 5

<li><a href="#" >Home </a></li>

groupCopy.jsp

line 9

<li><a href="index.html">Home </a></li>

groupDelete.jsp

line 9

<li><a href="index.html">Home </a></li>

groupRemoveMembers.jsp

line 9

<li><a href="index.html">Home </a></li>

groupMove.jsp

line 9

<li><a href="index.html">Home </a></li>

groupHeader.jsp

line 7

<li><a href="index.html">Home </a></li>

myGroupsMemberships.jsp

line 6

<li><a href="index.html">Home </a></li>

myGroups.jsp

line 6

<li><a href="index.html">Home </a></li>

myGroupsJoin.jsp

line 6

<li><a href="index.html">Home </a></li>

myStems,jsp

line 6

<li><a href="index.html">Home </a></li>

myStemsContainingGroupsImanage.jsp

line 6

<li><a href="index.html">Home </a></li>

myStemsContainingAttributesImanage.jsp

line 6

<li><a href="index.html">Home </a></li>

groupImportReport.jsp

line 9

<li><a href="index.html">Home </a></li>

groupExport.jsp

line 9

<li><a href="index.html">Home </a></li>

groupImport.jsp

line 9

<li><a href="index.html">Home </a></li>

search.jsp

line 6

<li><a href="index.html">Home </a></li>

line 11

<li><a href="#" >Home </a></li>

myFavorites.jsp

line 6

<li><a href="index.html">Home </a></li>

myServices.jsp

line 6

<li><a href="index.html">Home </a></li>

Thanks,
Yoann.

RE: [grouper-users] words/sentences directly in english in some JSP files, Chris Hyzer, 11/04/2014
- Re: [grouper-users] words/sentences directly in english in some JSP files, Yoann Delattre, 11/07/2014
  - RE: [grouper-users] words/sentences directly in english in some JSP files, Chris Hyzer, 11/07/2014
  - RE: [grouper-users] words/sentences directly in english in some JSP files, Chris Hyzer, 11/08/2014
    - Re: [grouper-users] words/sentences directly in english in some JSP files, Yoann Delattre, 11/17/2014
      - RE: [grouper-users] words/sentences directly in english in some JSP files, Chris Hyzer, 11/17/2014
        
        Re: [grouper-users] words/sentences directly in english in some JSP files, Yoann Delattre, 11/19/2014

List archive

Re: [grouper-users] words/sentences directly in english in some JSP files