Grouper Users - Open Discussion List

[Tom Barton <>]

Sorry I wasn't clear. The diff I sent is to one of the UI code modules, 
which must be adapted to a change in the API that was checked in after 
the 1.0 release.

And you're right, there's also a change in GrouperHelper.java. I've 
attached both diffs to this message. And I double-checked (this time) 
that these two files contain the only changes needed to get the 1.0 UI 
working with HEAD version of the API.

Tom

Mark Weber wrote:
> that must be fixed in HEAD version of the API, because I didn't have any 
> troubles building the API.  It was in the UI.  with GrouperHelper.java. 
>  I'm assuming I should I make the same changes in the UI to static calls?
>
> Also, do you have any preference as to how these fixes get communicated 
> back to the core developers.  Should I create diff's and send those 
> along?  Or should we handle it more formally by communicating the 
> problem and letting the developers fix the problems, check em in etc.?
>
> Just want to know because we are starting our testing so we may have a 
> few of these things pop up.
>
> Thanks,
> --Mark
>
> Tom Barton wrote:
> > Mark,
> >
> > The issue is the HEAD version of grouper-api, which has a changed 
> > interface to the config methods. But it's easy to deal with - replace 
> > occurrences of methods on objects created by 
> > GrouperConfig.getInstance() with static calls to the same methods on 
> > the GrouperConfig class itself.
> >
> > When I encountered this earlier this month, there were only two 
> > instances needing change, both in LowLevelGrouperCapableAction.java. 
> > I've attached the diff to fix it.
> >
> > Tom
> >
> > Mark Weber wrote:
> > > latest UI cvs build fails to compile.
> > > --Mark
> > >
> > > details:
> > >
> > > -compileGrouper:
> > >     [javac] Compiling 2 source files to 
> > > /home/mgweber/g2/dist/grouper/WEB-INF/classes
> > >     [javac] 
> > > /home/mgweber/g2/grouper-ui/java/src/edu/internet2/middleware/grouper/GrouperHelper.java:2333: 
> > > cannot find symbol
> > >     [javac] symbol  : method getInstance()
> > >     [javac] location: class 
> > > edu.internet2.middleware.grouper.GrouperConfig
> > >     [javac]             GrouperConfig config = 
> > > GrouperConfig.getInstance();
> > >     [javac]                                                     ^
> > >     [javac] Note: Some input files use unchecked or unsafe operations.
> > >     [javac] Note: Recompile with -Xlint:unchecked for details.
> > >     [javac] 1 error
> > >
> > > BUILD FAILED
> > > /home/mgweber/g2/grouper-ui/build.xml:35: The following error 
> > > occurred while executing this line:
> > > /home/mgweber/g2/grouper-ui/build.xml:583: The following error 
> > > occurred while executing this line:
> > > /home/mgweber/g2/grouper-ui/build.xml:119: The following error 
> > > occurred while executing this line:
> > > /home/mgweber/g2/grouper-ui/build.xml:94: The following error 
> > > occurred while executing this line:
> > > /home/mgweber/g2/grouper-ui/build.xml:492: The following error 
> > > occurred while executing this line:
> > > /home/mgweber/g2/grouper-ui/build.xml:247: Compile failed; see the 
> > > compiler error output for details.
*** GrouperHelper.java.org      2006-09-11 13:49:17.000000000 -0500
--- GrouperHelper.java  2006-09-11 13:53:03.000000000 -0500
***************
*** 2332,2337 ****
                String priv;
!               GrouperConfig config = GrouperConfig.getInstance();
                for(int i=0;i<groupPrivs.length;i++){
                        priv = groupPrivs[i].toLowerCase();
!                       
if("true".equals(config.getProperty("groups.create.grant.all." + priv))){
                                privs.put(priv,Boolean.TRUE);
--- 2332,2338 ----
                String priv;
! /* tjb 11 sep 2006            GrouperConfig config = 
GrouperConfig.getInstance(); */
                for(int i=0;i<groupPrivs.length;i++){
                        priv = groupPrivs[i].toLowerCase();
! /* tjb 11 sep 2006                    
if("true".equals(config.getProperty("groups.create.grant.all." + priv))){ */
!               
if("true".equals(GrouperConfig.getProperty("groups.create.grant.all." + 
priv))){ 
                                privs.put(priv,Boolean.TRUE);
*** LowLevelGrouperCapableAction.java.org       2006-09-11 13:55:54.000000000 
-0500
--- LowLevelGrouperCapableAction.java   2006-09-11 13:56:39.000000000 -0500
***************
*** 361,363 ****
                if(obj==null) {
!                       
if("true".equals(GrouperConfig.getInstance().getProperty("groups.wheel.use")))
 {
                                try {
--- 361,363 ----
                if(obj==null) {
!                       
if("true".equals(GrouperConfig.getProperty("groups.wheel.use"))) {
                                try {
***************
*** 365,367 ****
                                        GrouperSession s = 
GrouperSession.start(subj);
!                                       
obj=GroupFinder.findByName(s,GrouperConfig.getInstance().getProperty("groups.wheel.group"));
                                        
session.getServletContext().setAttribute("wheelGroup",obj);
--- 365,367 ----
                                        GrouperSession s = 
GrouperSession.start(subj);
!                                       
obj=GroupFinder.findByName(s,GrouperConfig.getProperty("groups.wheel.group"));
                                        
session.getServletContext().setAttribute("wheelGroup",obj);