Grouper Developers Forum

[Nicolas Marcotte <>]

I have done your request 1 (https://bugs.internet2.edu/jira/browse/GRP-1366 but i could not change the status)  and 2 (https://github.com/Internet2/grouper/pull/63) but I am not quite sure on the stylistically correct way to implement #3 so I will leave it to you.

Nicolas Marcotte
Analyste technologique – Architecture, conception et développement
Système d’information - Service des technologies de l'information
Université de Sherbrooke
Tél:  819 821-8000 poste 63276       
Courriel : 

On 08/26/2016 11:32 AM, Hyzer, Chris wrote:

That’s great!  Thanks so much.  Can I ask some favors?

 

1.       Can you make a jira and mark as resolved?  (if you don’t have access I can do this)

2.       Can you submit a pull request through github?

3.       Can you provide an option from the grouper properties that defaults to on for this enhancement, so if someone has a problem with it they can turn it off?

 

If you cant or don’t have time to do any of these I can do them for you

 

Thanks

Chris

 

From: [] On Behalf Of Nicolas Marcotte
Sent: Friday, August 26, 2016 11:06 AM
To:
Subject: [grouper-dev] JLine integration into gsh

 

Hello,
I am currently evaluating grouper for my institution and I was about to be driven mad by the line handling of gsh. To avoid that unfortunate I took 2 hours to integrate JLine2 to gsh interactive mode. I submit you my patch-set with the copyright attributed to Internet2.

Here are the feature added to gsh:
-platform independent arrows key handling
-sh style history

-minimal tab completion: the suggestions are from the current bsh dictionary and the lower case classes from package edu.internet2.middleware.grouper.app.gsh without contextual awareness....

I hope that this patch-set will help others to avoid getting mad at gsh !

Have a nice day!!
Nicolas

Nicolas Marcotte

Analyste technologique – Architecture, conception et développement

Système d’information - Service des technologies de l'information

Université de Sherbrooke

Tél:  819 821-8000 poste 63276       

Courriel :