grouper-dev - [grouper-dev] RE: [grouper] Implementation of missing parts of VOOT connector (#15)

Subject: Grouper Developers Forum

List archive

[grouper-dev] RE: [grouper] Implementation of missing parts of VOOT connector (#15)

From: Chris Hyzer <>
To: Internet2/grouper <>, Internet2/grouper <>
Cc: "" <>, Andrea Biancini <>
Subject: [grouper-dev] RE: [grouper] Implementation of missing parts of VOOT connector (#15)
Date: Mon, 3 Nov 2014 01:49:32 +0000
Accept-language: en-US

Andrea, thanks for making the changes and resubmitting the pull request.

Theres still some minor formatting diffs, but its good enough so I merged it J

Fyi, this one:

- public void setName(String name1) {

- this.name = name1;

+ public void setName(String name) {

+ this.name = name;

Gives a warning in my ide since “name” the variable hides a member field, so that’s why I make the param a little different from the field name. Not a big deal though

Thanks,

Chris

From: Andrea Biancini [mailto:]
Sent: Sunday, November 02, 2014 5:36 AM
To: Internet2/grouper
Subject: [grouper] Implementation of missing parts of VOOT connector (#15)

In this pull request I forward an update to the VOOT connector that, in respect to the previous implementation:

implements all the API endpoints of the VOOT protocol
implements the management of additional parameters (like search, startIndex, count, sortBy)
reviews code style, comments and some package name.

This development is still under-tested (since no JUnit has yet been created for it) however has been humanly tested on an existing Grouper 2.2.0 instance.

You can merge this Pull Request by running

  git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

https://github.com/Internet2/grouper/pull/15

Commit Summary

Implemented all the handpoints of the VOOT protocol
Correct email type
Added pagination and sorting
Reviewed comments, removed unused code and eliminated magic strings
Reviewed comments, removed unused code and eliminated magic strings
Renamed message package
Renamed message package
Correct indetantion with grouper standard 2 spaces instead of tabs

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub.