Grouper Developers Forum

[Andrea Biancini <>]

Yes,
Probably my IDE changed indentatindentation...

Actually, however, if not any, most of the lines will be changed...

I will indento with 2 spaces instead of tab and send back the pull request.

Cheers,
Andrea

Il 01/nov/2014 12:42 "Chris Hyzer" <> ha scritto:

Andrea, thanks a lot for your pull request to fix the grouper-voot connector.

 

https://github.com/Internet2/grouper/pull/14/files

 

The diff in github says every line changed, can you please correct the indentation so it is the grouper standard 2 spaces and not tabs?  I wonder if that’s why github says every line changed, hopefully not a line ending issue too.  Do you mind correcting that and submitting another pull request so that the pull request says only changed lines have changed so its easier to diff and consistent with other Grouper code?  J

 

Thanks,

Chris

 

 

 

From: Andrea Biancini [mailto:]
Sent: Saturday, November 01, 2014 12:33 PM
To: Internet2/grouper
Subject: [grouper] Implementation of missing parts of VOOT connector (#14)

 

In this pull request I forward an update to the VOOT connector that, in respect to the previous implementation:

• implements all the API endpoints of the VOOT protocol
• implements the management of additional parameters (like search, startIndex, count, sortBy)
• reviews code style, comments and some package name.

This development is still under-tested (since no JUnit has yet been created for it) however has been humanly tested on an existing Grouper 2.2.0 instance.

---

You can merge this Pull Request by running

  git pull https://github.com/biancini/grouper master

Or view, comment on, or merge it at:

  https://github.com/Internet2/grouper/pull/14

Commit Summary

• Implemented all the handpoints of the VOOT protocol
• Correct email type
• Added pagination and sorting
• Reviewed comments, removed unused code and eliminated magic strings
• Reviewed comments, removed unused code and eliminated magic strings
• Renamed message package
• Renamed message package

File Changes

• M grouper-misc/grouper-voot/README.txt (16)
• M grouper-misc/grouper-voot/build.xml (8)
• D grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/GrouperVoot.java (15)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/VootLogic.java (631)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/VootRestHttpMethod.java (17)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/VootServlet.java (246)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootEmail.java (71)
• D grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGetGroupsResponse.java (32)
• D grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGetMembersResponse.java (32)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootGroup.java (271)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootPerson.java (282)
• D grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/beans/VootResponse.java (93)
• A grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootErrorResponse.java (81)
• A grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetGroupsResponse.java (107)
• A grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootGetMembersResponse.java (107)
• A grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/messages/VootResponse.java (110)
• M grouper-misc/grouper-voot/src/edu/internet2/middleware/grouperVoot/restLogic/VootWsRest.java (352)

Patch Links:

• https://github.com/Internet2/grouper/pull/14.patch
• https://github.com/Internet2/grouper/pull/14.diff

—
Reply to this email directly or view it on GitHub.