Grouper Developers Forum

[Chris Hyzer <>]

Gary,

I search for "jo" in Penn's deployment, and there should be thousands of 
results (well, not sure how many).  The admin UI says there are 151 results, 
and doesn't say there are too many to narrow my search, and lets me page 
through the 151 results.

If the UI doesn't know how many results there are (its not in the subject 
API), and cant page through all the results (not in the subject API), then we 
shouldn't have paging on the admin UI.

Can we please make sure there is a message when there are too many results (I 
think you figured out how to do that below), and remove the subject paging 
buttons from the screen, and the part that says how many results there are?

Thanks,
Chris

-----Original Message-----
From: 

 
[mailto:]
 On Behalf Of GW Brown, Information Systems and Computing
Sent: Thursday, December 08, 2011 4:16 PM
To: Emily Eisbruch; Grouper Dev
Subject: Re: [grouper-dev] Action Items: Grouper-dev call 7-Dec-2011

--On 07 December 2011 16:07 -0500 Emily Eisbruch 
<>
 
wrote:

> [AI] (Gary) will look at the issue of paging in the Admin UI
> https://bugs.internet2.edu/jira/browse/GRP-716

I've looked at this again and still don't see a *paging* issue - The UI 
appears to correctly page based on whatever number of results are returned 
by the API - it doesn't care about what may have been discarded.

I did find one inconsistency in the code. The UI does subject searches in 
two classes:
1) DoSearchSubjectAction
2) SearchNewMembersAction

The former has:
  results=source.search(processedSearchTerm);
but should have:
  results=SubjectFinder.findPage(processedSearchTerm,sourceId).getResults();

I'm not convinced by the semantics of:

<!-- if more than this many results are returned, then throw a too many 
subjects exception -->
     <init-param>
       <param-name>maxResults</param-name>
       <param-value>1000</param-value>
     </init-param>

    <!-- on a findPage() this is the most results returned -->
    <init-param>
      <param-name>maxPageSize</param-name>
      <param-value>40</param-value>
    </init-param>

(I set maxPageSize to 40 down from 100 for testing.)

I think Chris was saying to ignore maxResults - in which case it should be 
removed from the sample sources.xml. I can then see that you can do:

SearchPageResult spr = null;
spr = SubjectFinder.findPage(searchTerm);
results = spr.getResults();
if(spr.isTooManyResults()) {
  request.setAttribute("message",
 new Message("error.too.many.subject.results",true));
}

That way the retrieved results are shown but the user is alerted to the 
fact the result set was truncated (error message might make that clearer)

Chris: if that is what you want it is an easy enough change. If you still 
think there is a UI paging issue you'll have to come up with a screenshot...

Gary


----------------------
GW Brown, IT Services