COmanage Developers List

[Tom Zeller <>]

> Cake 3 has a quoteIdentifier() function on the database driver that does
> that, but Cake 2 does not appear to have an equivalent. As such, for now
> I don't think we can quote keywords since we don't want to hack around
> in the core code. We should file a JIRA for FUTURE and have it depend on
> CO-1073.

Okay, will do.

> That leaves us with two options:
>
> (1) Maintain a list of reserved keywords and write a custom validator.
> (2) Update the documentation to say "don't use a reserved keyword".

I'd update the wiki but I don't have access to spaces.internet2.edu, sigh.

> Maybe also put a note in the appropriate form field.

https://github.com/Internet2/comanage-registry/pull/23

> I'm inclined to go with (2). This is an edge case.

Agree. The list of reserved keywords would probably eventually get stale 
anyway.

> It appeared CO-1441 actually had a second issue (table already exists)
> reported? Or maybe that got covered by a separate ticket?

Same issue. The check for whether or not to create the table is done
by counting cm_co_extended_attributes, which will be 0 if "starting
from scratch" and then trying to create an extended attribute using a
reserved word. I guess the logic could be improved when deciding
whether or not to create the table, but that won't fix the use of a
reserved word, so I don't think time should be spent on it.

Tom