COmanage Developers List

[Benn Oshrin <>]

Cake 3 has a quoteIdentifier() function on the database driver that does
that, but Cake 2 does not appear to have an equivalent. As such, for now
I don't think we can quote keywords since we don't want to hack around
in the core code. We should file a JIRA for FUTURE and have it depend on
CO-1073.

That leaves us with two options:

(1) Maintain a list of reserved keywords and write a custom validator.
(2) Update the documentation to say "don't use a reserved keyword".
Maybe also put a note in the appropriate form field.

I'm inclined to go with (2). This is an edge case.

It appeared CO-1441 actually had a second issue (table already exists)
reported? Or maybe that got covered by a separate ticket?

Thanks,

-Benn-

On 6/5/17 5:26 PM, Tom Zeller wrote:
> It looks like the fundamental error in CO-1441 is attempting to create
> a column whose name is a reserved SQL word (in MySQL) : 'int1'.
> 
> One fix is to escape the column name / reserved word. Another is to
> dis-allow reserved words.
> 
> Anyone know if there is a db-agnostic function in PHP or CakePHP for
> escaping SQL strings ?
> 
> I see mysqli->real_escape_string() and pg_escape_string(), but
> obviously those are db-specific.
> 
> Thanks !
> Tom
> 
> https://dev.mysql.com/doc/refman/5.5/en/keywords.html
>