COmanage Developers List

[Scott Koranda <>]

> On 11/5/12 6:27 PM, Scott Koranda wrote:
> 
> >>Does this really need to be in a constructor, as opposed to (say)
> >>beforeFilter?
> >
> >I do not know. We would have to be sure it is called early enough so
> >that the current shell application 'setup' is able to detect it.
> >
> >>We don't override constructors anywhere else, and I'd like to
> >>avoid it if we can.
> >
> >Why?
> 
> It's not the best way to extend functionality within cake. Note, for
> example, that you needed to copy a set of parameters that aren't
> exactly a published API. There are various defined extension points
> (beforeFilter, etc), and we should use those wherever possible.
> 
> Also, various posts to the cake list suggest the core developers
> don't see this as a preferred option.

Fair enough. We should use the framework as they intend it to
be used.

> 
> Note the excerpt I quoted was from Model/CoGroup. SetupShell already
> pulls the config information directly, so if this is about setup
> calling CoGroup->save(), then I'm definitely not convinced this
> needs to be done in the constructor.

Ok, I created CO-503 to change this.

> 
> >>Incidentally, "if (!" is not compliant with the coding guide.
> >
> >Which part of the guide specifically?
> 
> https://spaces.internet2.edu/display/COmanage/COmanage+Coding+Style#COmanageCodingStyle-Whitespace
> 

Oh, I see. It is the space and not the "!" that concerns you. Yes, typo.

Do you want a Jira to fix something like that or can I just
fix and push or just leave it to the next time the file is
touched?

Cheers,

Scott