COmanage Developers List

[Benn Oshrin <>]

On 10/25/12 6:56 PM, 

 wrote:
> +  /**
> +   * Constructor
> +   * - precondition:
> +   * - postcondition:
> +   *
> +   * @since COmanage Directory 0.7
> +   * @return instance
> +   */
> +  public function __construct($id = false, $table = null, $ds = null){
> +
> +    // Depending on the configuration use the Grouper
> +    // plugin data source or the default data source.
> +    if (Configure::read('Grouper.COmanage.useGrouperDataSource')) {
> +      $this->useDbConfig = 'grouperCoGroup';
> +    }
> +
> +    // Depending on the configuration signal that we
> +    // do not use a SQL relational database backend for the
> +    // data source.
> +    if (!Configure::read('COmanage.groupSqlDataSource')) {
> +      $this->usesSqlDataSource = false;
> +    }
> +
> +    parent::__construct($id, $table, $ds);
> +  }

Does this really need to be in a constructor, as opposed to (say) 
beforeFilter? We don't override constructors anywhere else, and I'd like 
to avoid it if we can.

Incidentally, "if (!" is not compliant with the coding guide.

-Benn-