COmanage Developers List

[Scott Koranda <>]

> Can you link to the previous issue 

Done.

> and add this to the Pasadena
> agenda? 

Done.

Thanks,

Scott

> Or we can discuss on tomorrow's call.
> 
> If you just need to get it working, I'd take the same override
> approach and we can double back if we come up with something else.
> 
> -Benn-
> 
> On 3/1/12 10:41 AM, Scott Koranda wrote:
> >Hi,
> >
> >I am happy to assign this issue to me but want input on how best to solve 
> >this.
> >
> >My first thought is to override the edit() method in the
> >CoPersonController class and to set the org_identity_id there before
> >calling the parent's edit() method in the StandardController.
> >
> >Thoughts?
> >
> >Thanks,
> >
> >Scott
> >
> >
> >---------- Forwarded message ----------
> >From: Scott Koranda 
> >(JIRA)<>
> >Date: Thu, Mar 1, 2012 at 9:26 AM
> >Subject: [JIRA] (CO-261) error
> >To: 
> >
> >
> >
> >
> >    [ 
> > https://bugs.internet2.edu/jira/browse/CO-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558#comment-16558
> >]
> >
> >Scott Koranda commented on CO-261:
> >----------------------------------
> >
> >I verified that if we add
> >
> >
> >  function edit($id) {
> >   // The parent edit() method is overridden here so that for non REST 
> > calls
> >   // the validation can be relaxed to allow the normal saveAll() call
> >   // in the parent edit() method to complete without a validation error.
> >   // If the validation is not relaxed so that co_person_id and 
> > org_identity_id
> >   // are not required then the validation of all the tables before any 
> > updates
> >   // will cause a validation error for the model CoOrgIdentityLink.
> >
> >    if(!$this->restful) {
> >      $this->loadModel('CoOrgIdentityLink');
> >
> >      // dynamically relax the validation for the CoOrgIdentityLink model
> >      $this->CoOrgIdentityLink->validate['co_person_id']['required'] = 
> > false;
> >      $this->CoOrgIdentityLink->validate['org_identity_id']['required'] = 
> > false;
> >    }
> >
> >    // call the add() method for the parent StandardController class
> >    parent::edit($id);
> >  }
> >
> >to CoPeopleController.php then the problem goes away.
> >
> >So this is the second instance we are faced with of the validation at
> >the model level causing a problem, in particular the validation that
> >requires the co_person_id and org_identity_id to be known at the same
> >time.
> >
> >Of course for this issue edit() should be able to know both the
> >co_person_id and the org_identity_id, unlike the case of add(), so
> >this is not really the same issue.
> >
> >>error
> >>------
> >>
> >>                 Key: CO-261
> >>                 URL: https://bugs.internet2.edu/jira/browse/CO-261
> >>             Project: COmanage
> >>          Issue Type: Bug
> >>          Components: Registry
> >>    Affects Versions: COmanage Registry 0.4 (Reshaped Cake)
> >>            Reporter: Scott Koranda
> >>            Assignee: Benn Oshrin
> >>            Priority: Critical
> >>              Labels: sprint04
> >>             Fix For: COmanage Registry 0.4 (Reshaped Cake)
> >>
> >>         Attachments: CoPersonEditError.png
> >>
> >>
> >>A user editing his or her CO identity receives an error to 'Please 
> >>recheck your submission'.
> >>I suspect this is the same problem due to validation that presented in 
> >>CO-242. That was fixed by adding a new add() method that relaxed 
> >>validation and then called the parent add() method in the 
> >>StandardController. That solution may not be the right one here.
> >
> >--
> >This message is automatically generated by JIRA.
> >If you think it was sent incorrectly, please contact your JIRA
> >administrators:
> >https://bugs.internet2.edu/jira/secure/ContactAdministrators!default.jspa
> >For more information on JIRA, see: http://www.atlassian.com/software/jira
>