COmanage Developers List

[Benn Oshrin <>]

On 1/30/12 12:44 PM, Scott Koranda wrote:

> > What's the advantage of creating a separate salts file vs just
> > editing app/Config/core.php?
>
> - easier to detect, parse, and manage a single line in a
>    single file
> - less likely to be put into SVN by accident
>
> > What if we distribute core.php.default
> > (like database.php.default) and generate core.php as part of setup?
>
> I prefer a separate file but will defer to you if you strongly
> prefer generating core.php.

Well, generating core.php from a default follows the pattern of the 
other files, but putting it into a separate file would make it easier to 
change core.php (ie: next time core changes).

Remember, it's two salts, not one, so the file won't be a single line.

I'm a little concerned about config file proliferation, but it's already 
a directory.

So I guess I'm leaning ever so slightly to a separate salt file.

> > I'd argue this should be part of setup rather than a third shell
> > command. This task only happens once -- at setup. I'm not concerned
> > about any existing installations at this point. In general, fewer
> > steps for deployers to run = better. Going from 2 to 3 isn't huge,
> > but over time the "just one more" argument ends up with a process
> > that will need to be refactored.
>
> I am fine with that. My only concern is that the salt gets
> baken in early and needs to happen before database.php is run.
> I simply do not know how early the salt is used.
>
> I can easily test that.

I don't think it's used in setup at all, so anywhere in there should be 
fine. But I look forward to your test :)

-Benn-