COmanage Developers List

[Scott Koranda <>]

> On 1/28/12 7:21 AM, Scott Koranda wrote:
> 
> >I added some comments and would like input on the path to follow.
> >
> >My preference is detailed in this comment:
> >
> >https://bugs.internet2.edu/jira/browse/CO-202?focusedCommentId=16272&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16272
> >
> >Shall I proceed with coding that up?
> 
> Capistrano seems like overkill.

Agreed.

> 
> What's the advantage of creating a separate salts file vs just
> editing app/Config/core.php? 

- easier to detect, parse, and manage a single line in a
  single file
- less likely to be put into SVN by accident

> What if we distribute core.php.default
> (like database.php.default) and generate core.php as part of setup?

I prefer a separate file but will defer to you if you strongly
prefer generating core.php.

Let me know...

> 
> I'd argue this should be part of setup rather than a third shell
> command. This task only happens once -- at setup. I'm not concerned
> about any existing installations at this point. In general, fewer
> steps for deployers to run = better. Going from 2 to 3 isn't huge,
> but over time the "just one more" argument ends up with a process
> that will need to be refactored.

I am fine with that. My only concern is that the salt gets
baken in early and needs to happen before database.php is run.
I simply do not know how early the salt is used.

I can easily test that.

> 
> The only reason database is separate is because the database schema
> can be updated after setup. Arguably, we should ditch database and
> make a separate upgrade shell, but we can worry about that when we
> have changes that need to be made automatically for upgrading that
> aren't database related.
> 

Agreed.

Scott