Presence and IntComm WG

[Artem Dmytrenko <>]

Ben, I've fixed the typo mentioned in the other email.

On 1 Oct 2003, Ben Teitelbaum wrote:
> Auditing your PHP code more carefully, I see two bugs.
> First, there is a race condition.  Two users simultaneously confirming
> and executing the confirm_email() function could step all over each
> other.  Please add file locking to prevent this possibility or
> re-implement statelessly with an MD5 checksum of $email . $first_name
> . $last_name . $secret_salt.

I will fix this later on today (I need a little time to fix this - and I
have a class in 10 minutes).

>
> Secondly, the flow control is broken in the case where the user has
> already registered.  If the conditional ($status == "pending") fails,
> the script still prints:

Ben, this is how I planned it to work. E.g. if it's initial registration,
add user to the database. If they come back again to the same link, the
script will not re-register them, but simply print registration
successfull link again. This way they can register today, and come back to
the same link a week later to buy the headphones without calling 'add_ser'
twice.

If you would like to print a different message on subsequent visits, I can
modify the script to do just that.

Art.

----------------------------------------------------------------wg-pic-+
For list utilities, archives, subscribe, unsubscribe, etc. please visit the
ListProc web interface at 

    http://archives.internet2.edu/

----------------------------------------------------------------wg-pic--