Shibboleth Developers

[Chad La Joie <>]

Okay, it appears this the only unit test that broke.  I'll figure out a
better way to do this test and get it fixed up.

On 6/2/11 4:38 PM, Chad La Joie wrote:
> Yeah, that test is actually brittle to begin with, this change just
> highlighted one of the ways it's not so great.  I'll be double checking
> all our projects now that all the changes have been made.
> 
> On 6/2/11 2:59 PM, ejc wrote:
>> It looks as though some tests will need to be checked.  I checked out
>> https://svn.shibboleth.net/java-shib-common/branches/REL_1
>>
>> and ran mvn package
>>
>> src/test/java/edu/internet2/middleware/shibboleth/common/resource/SVNResourceTest.java
>> failed because src/main/resources/schema/shibboleth-2.0-resource.xsd
>> changed size
>>
>> This patch fixes the test:
>>
>> Index: 
>> src/test/java/edu/internet2/middleware/shibboleth/common/resource/SVNResourceTest.java
>> ===================================================================
>> --- 
>> src/test/java/edu/internet2/middleware/shibboleth/common/resource/SVNResourceTest.java
>>    (revision
>> 979)
>> +++ 
>> src/test/java/edu/internet2/middleware/shibboleth/common/resource/SVNResourceTest.java
>>    (working
>> copy)
>> @@ -81,7 +81,7 @@
>>          // directory should contain the 19 schema files plus the .svn 
>> directory
>>          assertEquals(20, workingCopyDirectory.list().length);
>>          assertTrue(schemaFile.exists());
>> -        assertEquals(5161, schemaFile.length());
>> +        assertEquals(5148, schemaFile.length());
>>          assertTrue(resource.exists());
>>          assertEquals("file://" + repoDir.getAbsolutePath() + "/" +
>> schemaFileName, resource.getLocation());
>>
>> @@ -95,7 +95,7 @@
>>          assertEquals("file://" + repoDir.getAbsolutePath() + "/" +
>> schemaFileName, resource.getLocation());
>>          assertEquals(20, workingCopyDirectory.list().length);
>>          assertTrue(schemaFile.exists());
>> -        assertEquals(5161, schemaFile.length());
>> +        assertEquals(5148, schemaFile.length());
>>
>>          // getLastModified() should force an update
>>          assertTrue(lastModified.isBefore(resource.getLastModifiedTime()));
>>
>> Thanks,
>> Eric
>>
>> On Mon, May 30, 2011 at 7:49 AM, Chad La Joie 
>> <>
>>  wrote:
>>> Mid-week Brent is going to be checking in two changes that will effect
>>> most files in our Java repositories.
>>>
>>> First, he'll be fixing up the license header used by our source code.
>>> It'll still be Apache 2 licensed, we're just moving to a model that
>>> makes it easier for us to track which organizations contributed code.
>>>
>>> Second, we'll be fixing up two SVN properties on most of our files:
>>>  - svn:eol-style will be set to native on our text files (so when you
>>> check out files it'll convert line endings to your platform's native
>>> character(s))
>>>  - svn:mime-type property will be removed from all files that don't
>>> have a registered MIME type (mostly source files) and will be properly
>>> set for those that do.  This helps our SVN web view do syntax
>>> highlighting as well as just being good housekeeping.
>>>
>>> Developers, please be sure to adjust your SVN clients as described in
>>> the documents below.  This will ensure that all new files have the
>>> proper SVN properties set automatically.
>>>   - Command line: 
>>> https://wiki.shibboleth.net/confluence/display/DEV/SVNConfig
>>>   - Eclipse: 
>>> https://wiki.shibboleth.net/confluence/display/DEV/EclipseConfig
>>>
>>> --
>>> Chad La Joie
>>> www.itumi.biz
>>> trusted identities, delivered
>>>
>>
> 

-- 
Chad La Joie
http://itumi.biz
trusted identities, delivered